Re: [PATCH, GDB 6.8] Build Insight correctly on a MinGW system

Re: [PATCH, GDB 6.8] Build Insight correctly on a MinGW system

[Daniel Jacobowitz]

On Fri, Apr 11, 2008 at 11:14:54AM +0200, Hans Kester wrote:
> The following patch builds Insight correctly on a MinGW system.
> Could someone commit this for me?

Copying this to the Insight maintainers.

> 
> Regards,
> 
> Hans Kester
> 
> 
> Index: gdb/ChangeLog
> ===================================================================
> RCS file: /cvs/src/src/gdb/ChangeLog,v
> retrieving revision 1.9174.2.20
> diff -u -r1.9174.2.20 ChangeLog
> --- ChangeLog   31 Mar 2008 03:40:42 -0000   1.9174.2.20
> +++ ChangeLog   11 Apr 2008 09:10:13 -0000
> @@ -1,3 +1,8 @@
> +2008-04-11  Hans Kester  <kester.hans@gmail.com>
> +
> +   * configure.ac: Added configdir for MinGW.
> +   * configure:    Added configdir for MinGW.
> +
>  2008-03-30  Daniel Jacobowitz  <dan@codesourcery.com>
> 
>     * ia64-tdep.c (examine_prologue): Correct array access.
> 
> 
> 
> Index: gdb/configure.ac
> ===================================================================
> RCS file: /cvs/src/src/gdb/configure.ac,v
> retrieving revision 1.64
> diff -u -r1.64 configure.ac
> --- configure.ac   13 Jan 2008 12:23:05 -0000   1.64
> +++ configure.ac   11 Apr 2008 09:02:13 -0000
> @@ -1445,7 +1445,7 @@
>  AC_SUBST(WIN32LDAPP)
> 
>  case "${host}" in
> -*-*-cygwin*)
> +*-*-cygwin* | *-*-mingw*)
>      configdir="win"
>      ;;
>  *)
> 
> 
> 
> Index: gdb/configure
> ===================================================================
> RCS file: /cvs/src/src/gdb/configure,v
> retrieving revision 1.242
> diff -u -r1.242 configure
> --- configure   13 Jan 2008 12:23:04 -0000   1.242
> +++ configure   11 Apr 2008 09:05:54 -0000
> @@ -23080,7 +23080,7 @@
> 
> 
>  case "${host}" in
> -*-*-cygwin*)
> +*-*-cygwin* | *-*-mingw*)
>      configdir="win"
>      ;;
>  *)
> 

-- 
Daniel Jacobowitz
CodeSourcery

Re: [PATCH, GDB 6.8] Build Insight correctly on a MinGW system

[Dave Murphy]

Daniel Jacobowitz wrote:
> On Fri, Apr 11, 2008 at 11:14:54AM +0200, Hans Kester wrote:
>> The following patch builds Insight correctly on a MinGW system.
>> Could someone commit this for me?
> 
> Copying this to the Insight maintainers.

This was already committed to CVS back in March

http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/configure.ac.diff?r1=1.64&r2=1.65&cvsroot=src&f=h

Dave

>> Index: gdb/ChangeLog
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/ChangeLog,v
>> retrieving revision 1.9174.2.20
>> diff -u -r1.9174.2.20 ChangeLog
>> --- ChangeLog   31 Mar 2008 03:40:42 -0000   1.9174.2.20
>> +++ ChangeLog   11 Apr 2008 09:10:13 -0000
>> @@ -1,3 +1,8 @@
>> +2008-04-11  Hans Kester  <kester.hans@gmail.com>
>> +
>> +   * configure.ac: Added configdir for MinGW.
>> +   * configure:    Added configdir for MinGW.
>> +
>>  2008-03-30  Daniel Jacobowitz  <dan@codesourcery.com>
>>
>>     * ia64-tdep.c (examine_prologue): Correct array access.
>>
>>
>>
>> Index: gdb/configure.ac
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/configure.ac,v
>> retrieving revision 1.64
>> diff -u -r1.64 configure.ac
>> --- configure.ac   13 Jan 2008 12:23:05 -0000   1.64
>> +++ configure.ac   11 Apr 2008 09:02:13 -0000
>> @@ -1445,7 +1445,7 @@
>>  AC_SUBST(WIN32LDAPP)
>>
>>  case "${host}" in
>> -*-*-cygwin*)
>> +*-*-cygwin* | *-*-mingw*)
>>      configdir="win"
>>      ;;
>>  *)
>>
>>
>>
>> Index: gdb/configure
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/configure,v
>> retrieving revision 1.242
>> diff -u -r1.242 configure
>> --- configure   13 Jan 2008 12:23:04 -0000   1.242
>> +++ configure   11 Apr 2008 09:05:54 -0000
>> @@ -23080,7 +23080,7 @@
>>
>>
>>  case "${host}" in
>> -*-*-cygwin*)
>> +*-*-cygwin* | *-*-mingw*)
>>      configdir="win"
>>      ;;
>>  *)
>>
> 

Re: [PATCH, GDB 6.8] Build Insight correctly on a MinGW system

[Hans Kester]

Dave Murphy <davem@devkitpro.org> wrote:
> This was already committed to CVS back in March
> http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/configure.ac.diff?r1=1.64&r2=1.65&cvsroot=src&f=h

But apparently not in the 6.8 branch since I checked that out and did
not see the patch. Or do I need more coffee?

Hans

Re: [PATCH, GDB 6.8] Build Insight correctly on a MinGW system

[Joel Brobecker]

> But apparently not in the 6.8 branch since I checked that out and did
> not see the patch. Or do I need more coffee?

I don't mind that this patch be put on the branch, but IFAIK, the
insight release cycle is different from the GDB one - so I was a bit
surprised that you tried to build insight from the gdb-6.8 branch.
I don't mind either, though. I just didn't know some people were
doing this.

-- 
Joel