Re: undefined reference to `set_breakpoint'

[Keith Seitz <keiths@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

On 03/17/2010 10:33 AM, Tom Tromey wrote:
>>>>>> "Gene" == Gene Smith<gds@chartertn.net>  writes:
> No, this is due to a change to gdb without a corresponding fix to
> insight.  This happens from time to time.

Do you want to test the attach patch? [I'm off the rest of the week, or 
I would probably have occasion to put it through its paces.]

Let me know if this works -- it was okay in preliminary testing.

Keith

ChangeLog
2010-03-17  Keith Seitz  <keiths@redhat.com>

	* generic/gdbtk-bp.c (gdb_set_bp): set_breakpoint is no more.
	Use create_breakpoint.

[-- Attachment #2: set_breakpoint.patch --]
[-- Type: text/plain, Size: 1181 bytes --]

Index: generic/gdbtk-bp.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-bp.c,v
retrieving revision 1.33
diff -u -p -r1.33 gdbtk-bp.c
--- generic/gdbtk-bp.c	15 Jan 2010 22:37:18 -0000	1.33
+++ generic/gdbtk-bp.c	17 Mar 2010 17:56:54 -0000
@@ -1,5 +1,5 @@
 /* Tcl/Tk command definitions for Insight - Breakpoints.
-   Copyright (C) 2001, 2002, 2008, 2009 Free Software Foundation, Inc.
+   Copyright (C) 2001, 2002, 2008, 2009, 2010 Free Software Foundation, Inc.
 
    This file is part of GDB.
 
@@ -530,9 +530,16 @@ gdb_set_bp (ClientData clientData, Tcl_I
 
   TRY_CATCH (e, RETURN_MASK_ALL)
     {
-      set_breakpoint (get_current_arch (), address, condition,
-		      0 /* hardwareflag */, temp, thread, ignore_count,
-		      pending, enabled);
+      create_breakpoint (get_current_arch (), address, condition, thread,
+			 0	/* condition and thread are valid */,
+			 temp,
+			 0	/* hardware flag */,
+			 0	/* trace flag */,
+			 ignore_count,
+			 (pending ? AUTO_BOOLEAN_TRUE : AUTO_BOOLEAN_FALSE),
+			 NULL	/* breakpoint ops */,
+			 0	/* from_tty */,
+			 enabled);
     }
 
   if (e.reason < 0)