From: Hui Zhu <teawater@gmail.com>
To: Keith Seitz <keiths@redhat.com>
Cc: insight@sources.redhat.com
Subject: Re: undefined reference to `set_breakpoint'
Date: Wed, 31 Mar 2010 04:12:00 -0000 [thread overview]
Message-ID: <y2zdaef60381003302019m3d925ae7u9b08c8d46541f897@mail.gmail.com> (raw)
In-Reply-To: <4BB22B62.3050402@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]
On Wed, Mar 31, 2010 at 00:48, Keith Seitz <keiths@redhat.com> wrote:
> On 03/30/2010 01:29 AM, Hui Zhu wrote:
>>
>> Ping. Did I miss something?
>>
>
> Nope -- I did. After the breakpoint commands API was fiddled with, I worked
> up the original patch. Some (brief) time after committing my patch, the API
> was fiddled with again.
>
> I apologize about the confusion. Try this patch, which I've committed.
>
> Keith
>
> ChangeLog
> 2010-03-30 Keith Seitz <keiths@redhat.com>
>
> * generic/gdbtk-bp.c (gdb_get_breakpoint_info): Breakpoint
> commands are now reference counted. Adjust data pointers.
> (gdb_get_tracepoint_info): Likewise.
> (gdb_actions_command): Don't free previous actions. If the
> commands aren't valid, we would prefer to keep the old ones
> any way. break_point_set_commands will also clobber any
> previous results anyway.
>
Hi Keith,
I try this patch bug cannot patch to cvs-head. The attachment is the
rej file that I got.
Thanks,
Hui
[-- Attachment #2: gdbtk-bp.c.rej --]
[-- Type: application/x-reject, Size: 2002 bytes --]
next prev parent reply other threads:[~2010-03-31 3:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 17:34 Gene Smith
2010-03-17 17:57 ` Tom Tromey
2010-03-18 3:39 ` Keith Seitz
2010-03-18 4:58 ` Gene Smith
2010-03-19 4:32 ` Gene Smith
2010-03-20 5:33 ` Hui Zhu
2010-03-30 8:29 ` Hui Zhu
2010-03-30 16:48 ` Hui Zhu
2010-03-31 3:20 ` Keith Seitz
2010-03-31 4:12 ` Hui Zhu [this message]
2010-03-31 4:28 ` Keith Seitz
2010-03-31 5:33 ` Hui Zhu
2010-03-31 5:37 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y2zdaef60381003302019m3d925ae7u9b08c8d46541f897@mail.gmail.com \
--to=teawater@gmail.com \
--cc=insight@sources.redhat.com \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).