public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: insight <insight@sourceware.org>
Subject: Re: [PATCH] Recent GDB prompt/bp API updates
Date: Tue, 02 Aug 2011 18:50:00 -0000	[thread overview]
Message-ID: <4E3846CB.5020900@redhat.com> (raw)
In-Reply-To: <4E372454.7010204@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

On 08/01/2011 03:10 PM, Keith Seitz wrote:
> If there are any problems, please let me know.

There was a problem: breakpoints could not be set through the Source 
Window. I have committed the attach patch to correct this.

Keith

ChangeLog
2011-08-02  Keith Seitz  <keiths@redhat.com>

	* generic/gdbtk-bp.c (gdb_set_bp): Pass a valid breakpoint_ops
	to create_breakpoint.

[-- Attachment #2: breakpoint_ops.patch --]
[-- Type: text/plain, Size: 587 bytes --]

Index: generic/gdbtk-bp.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-bp.c,v
retrieving revision 1.42
diff -u -p -r1.42 gdbtk-bp.c
--- generic/gdbtk-bp.c	1 Aug 2011 22:08:20 -0000	1.42
+++ generic/gdbtk-bp.c	2 Aug 2011 18:05:04 -0000
@@ -540,7 +540,7 @@ gdb_set_bp (ClientData clientData, Tcl_I
 			 bp_breakpoint /* type wanted */,
 			 ignore_count,
 			 (pending ? AUTO_BOOLEAN_TRUE : AUTO_BOOLEAN_FALSE),
-			 NULL	/* breakpoint ops */,
+			 &bkpt_breakpoint_ops,
 			 0	/* from_tty */,
 			 enabled, 0);
     }

  reply	other threads:[~2011-08-02 18:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-01 22:10 Keith Seitz
2011-08-02 18:50 ` Keith Seitz [this message]
2011-08-11 10:31   ` Dave Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E3846CB.5020900@redhat.com \
    --to=keiths@redhat.com \
    --cc=insight@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).