Re: [PATCH] Recent GDB prompt/bp API updates

[Dave Murphy <davem@devkitpro.org>]

[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]

On Tue, Aug 2, 2011 at 7:49 PM, Keith Seitz <keiths@redhat.com> wrote:
> On 08/01/2011 03:10 PM, Keith Seitz wrote:
>>
>> If there are any problems, please let me know.
>
> There was a problem: breakpoints could not be set through the Source Window.
> I have committed the attach patch to correct this.

>        * generic/gdbtk-bp.c (gdb_set_bp): Pass a valid breakpoint_ops
>        to create_breakpoint.

I see this change in CVS but a build of insight under msys/mingw still
can't seem to set breakpoints from the source window - this is for an
arm-eabi target if it makes any difference. Setting a breakpoint from
the console shows the red box in the source window and it can be
disabled from there just fine.

Also, oddly, some patching is needed to build with mingw/msys again
which I could have sworn was fixed some time ago. The patch is pretty
minor though. There's also a patch to config/tcl.m4 needed as well
which needs gdb/configure & gdb/gdbtk/plugins/configure regenerated -
does that belong to Insight or gdb? I've attached it here too.

2011-08-11  Dave Murphy  <davem@devkitpro.org>
       * libgui/configure.ac:  add mingw to win32 hosts
       * libgui/configure:     regenerate
       * tcl/win/tclWinChan.c  mark ESP/EBP as used
       * tcl/win/tclWinDde.c (Tcl_DdeObjCmd):  remove invalid lvalue cast

[-- Attachment #2: insight-mingw.patch --]
[-- Type: application/octet-stream, Size: 1918 bytes --]

Index: libgui/configure.ac
===================================================================
RCS file: /cvs/src/src/libgui/configure.ac,v
retrieving revision 1.4
diff -u -r1.4 configure.ac
--- libgui/configure.ac	2 Aug 2008 23:33:36 -0000	1.4
+++ libgui/configure.ac	11 Aug 2011 09:21:58 -0000
@@ -53,7 +53,7 @@
 fi
 
 case "${host}" in
-*-*-cygwin*)
+*-*-cygwin*|*-*-mingw*)
         touch ac$$.c
         if ${CC} -c -mwin32 ac$$.c >/dev/null 2>&1; then
             case "$LIBGUI_CFLAGS" in
@@ -65,7 +65,7 @@
         ;;
 esac
 case "${host}" in
-*-*-cygwin*)
+*-*-cygwin*|*-*-mingw*)
 	LIBGUI_CFLAGS="-DWIN32 $LIBGUI_CFLAGS" ;;
 esac
 AC_SUBST(LIBGUI_CFLAGS) 
@@ -93,7 +93,7 @@
 if test "${TCL_SRC_DIR}" = "${topdir}/tcl"; then
   # Using in-tree Tcl/Tk
   case "${host}" in
-    *-*-cygwin*) platDir="win" ;;
+    *-*-cygwin*|*-*-mingw*) platDir="win" ;;
     *) platDir="unix" ;;
   esac
 
Index: tcl/win/tclWinChan.c
===================================================================
RCS file: /cvs/src/src/tcl/win/tclWinChan.c,v
retrieving revision 1.6
diff -u -r1.6 tclWinChan.c
--- tcl/win/tclWinChan.c	2 Feb 2006 20:02:09 -0000	1.6
+++ tcl/win/tclWinChan.c	11 Aug 2011 09:22:06 -0000
@@ -122,8 +122,8 @@
 };
 
 #ifdef HAVE_NO_SEH
-static void *ESP;
-static void *EBP;
+static void *ESP __attribute__((used));
+static void *EBP __attribute__((used));
 #endif /* HAVE_NO_SEH */
 
 \f
Index: tcl/win/tclWinDde.c
===================================================================
RCS file: /cvs/src/src/tcl/win/tclWinDde.c,v
retrieving revision 1.5
diff -u -r1.5 tclWinDde.c
--- tcl/win/tclWinDde.c	21 Jan 2003 19:40:22 -0000	1.5
+++ tcl/win/tclWinDde.c	11 Aug 2011 09:22:06 -0000
@@ -1175,7 +1175,7 @@
 	}
 	case DDE_EVAL: {
 	    objc -= (async + 3);
-	    ((Tcl_Obj **) objv) += (async + 3);
+        objv += (async + 3);
 
             /*
 	     * See if the target interpreter is local.  If so, execute

[-- Attachment #3: tcl.m4.patch --]
[-- Type: application/octet-stream, Size: 775 bytes --]

Index: config/tcl.m4
===================================================================
RCS file: /cvs/src/src/config/tcl.m4,v
retrieving revision 1.3
diff -u -r1.3 tcl.m4
--- config/tcl.m4	2 Feb 2009 23:18:05 -0000	1.3
+++ config/tcl.m4	11 Aug 2011 10:24:29 -0000
@@ -33,7 +33,7 @@
 
 	    # First check to see if --with-tcl was specified.
 	    case "${host}" in
-		*-*-cygwin*) platDir="win" ;;
+		*-*-cygwin*|*-*-mingw*) platDir="win" ;;
 		*) platDir="unix" ;;
 	    esac
 	    if test x"${with_tclconfig}" != x ; then
@@ -165,7 +165,7 @@
 
 	    # then check for a private Tk library
 	    case "${host}" in
-		*-*-cygwin*) platDir="win" ;;
+		*-*-cygwin*|*-*-mingw*) platDir="win" ;;
 		*) platDir="unix" ;;
 	    esac
 	    if test x"${ac_cv_c_tkconfig}" = x ; then