From: Keith Seitz <keiths@redhat.com>
To: Roland Schwingel <roland@onevision.com>
Cc: insight@sourceware.org
Subject: Re: [PATCH] Remove deprecated access to tcl internal variables
Date: Tue, 27 Mar 2012 15:18:00 -0000 [thread overview]
Message-ID: <4F71D266.70601@redhat.com> (raw)
In-Reply-To: <4F716889.2080603@onevision.com>
On 03/27/2012 12:13 AM, Roland Schwingel wrote:
> Sorry... Sometimes it is hard to switch between the styles. I surely
> want to follow the GCS when submitting patches. Our company style is
> just (in some areas) vice versa.
Not a problem -- it happens to everyone. :-)
> If you give the ok to my patch(es) I can also
> do these final reformatting during commit.
That will be best/easiest. One other thing I noticed:
> else
> - actual_len = strlen (gdbtk_interp->result);
> + {
Here ^
> + const char *tclResult = Tcl_GetStringResult(gdbtk_interp);
> + actual_len = strlen (tclResult);
>
> /* Truncate the string if it is too big for the caller's
buffer. */
> if (actual_len >= sizeof_buf)
> actual_len = sizeof_buf - 1;
>
> - memcpy (buf, gdbtk_interp->result, actual_len);
> + memcpy (buf,tclResult, actual_len);
> buf[actual_len] = '\0';
> return actual_len;
> + }
> }
and here^ the identation level is off. Please adjust to follow the rest
of the code. [These should be emacs-default indentations IIRC.]
> I did not change behaviour here Keith. gdbtk_read() behaves the same as
> before it just takes a small shortcut in case gdbtk_console_read has failed
> (for some reasons).
Yes, you are right. I completely missed that. In any case, please add a
ChangeLog entry for it, adjust the two formatting/CS discrepancies and
this patch is good to go in.
Thanks!
Keith
next prev parent reply other threads:[~2012-03-27 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 7:13 Roland Schwingel
2012-03-27 15:18 ` Keith Seitz [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-28 14:53 Roland Schwingel
2012-03-19 11:46 Roland Schwingel
2012-03-23 22:25 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F71D266.70601@redhat.com \
--to=keiths@redhat.com \
--cc=insight@sourceware.org \
--cc=roland@onevision.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).