From: Roland Schwingel <roland@onevision.com>
To: insight@sourceware.org
Subject: Re: [PATCH] Remove deprecated access to tcl internal variables
Date: Wed, 28 Mar 2012 14:53:00 -0000 [thread overview]
Message-ID: <4F7325C6.6010807@onevision.com> (raw)
Hi Keith,
insight-owner@sourceware.org wrote on 27.03.2012 16:44:54:
> In any case, please add a
> ChangeLog entry for it, adjust the two formatting/CS discrepancies and
> this patch is good to go in.
I corrected the formatting of function calls and indents and expanded
the changelog and checked it in now.
New changelog:
2012-03-28 Roland Schwingel <roland.schwingel@onevision.com>
* generic/gdbtk.c (gdbtk_init,tk_command): Replace deprecated access
to tcl interpreter result string with Tcl_GetStringResult().
* generic/gdbtk-hooks.c (gdbtk_read,gdbtk_readline,gdbtk_load_hash)
(gdbtk_query): Likewise.
(gdbtk_read): Simplified error handling in case "gdbtk_console_read"
fails. Some reformatting.
Thanks for reviewing. :-)
Do you know when you will find time to look at my other patches?
At least the next four of my bulk are quite trivial.
Thanks,
Roland
next reply other threads:[~2012-03-28 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 14:53 Roland Schwingel [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-27 7:13 Roland Schwingel
2012-03-27 15:18 ` Keith Seitz
2012-03-19 11:46 Roland Schwingel
2012-03-23 22:25 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7325C6.6010807@onevision.com \
--to=roland@onevision.com \
--cc=insight@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).