public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: insight@sourceware.org
Subject: Sending patches upstream
Date: Sat, 21 Jan 2023 13:55:50 -0700	[thread overview]
Message-ID: <877cxfli95.fsf@tromey.com> (raw)

Hi.  I was looking through the Insight repo today and I think a couple
patches could go upstream:

* 003-tclconfig.patch
* 004-tcltkplatform.patch
* 007-gdbtk-obj-in-subdir.patch

As long as some gdbtk build stuff lives in upstream gdb, it should
probably just be directly patched there.

I'd somewhat prefer a variant that makes SUBDIR_GDBTK_OBS be computed
like the other _OBS variables, e.g.:

    SUBDIR_CLI_OBS = $(patsubst %.c,%.o,$(SUBDIR_CLI_SRCS))

However it might also make sense to just remove all the Tcl and gdbtk
configure and build code upstream, to be added back and maintained in
Insight...


* 009-windows-stop.patch

I think this can just go in with a suitable commit message.
It seems like a clear oversight.  I don't particularly understand why
gdb needs both 'stop' and 'interrupt' methods, though.

thanks,
Tom

                 reply	other threads:[~2023-01-21 20:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cxfli95.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=insight@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).