* Patch: Fix .gdbtkinit reading
@ 2001-08-21 14:39 Tom Tromey
2001-08-22 11:38 ` Keith Seitz
0 siblings, 1 reply; 6+ messages in thread
From: Tom Tromey @ 2001-08-21 14:39 UTC (permalink / raw)
To: Insight List
Currently Insight tries to encode preference values which include `='.
Unfortunately due to a small bug Insight doesn't properly re-read such
values.
I found this while trying to use a saved session. I tested the
appended patch on that session. Ok to commit?
Tom
Index: ChangeLog
from Tom Tromey <tromey@redhat.com>
* library/prefs.tcl (pref_read): Version number appears in
comment.
Index: library/prefs.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/prefs.tcl,v
retrieving revision 1.11
diff -u -r1.11 prefs.tcl
--- library/prefs.tcl 2001/08/09 20:43:54 1.11
+++ library/prefs.tcl 2001/08/21 21:39:37
@@ -78,7 +78,8 @@
{^[ \t\n]*#.*} {
# Comment. We recognize one magic comment that includes
# the version number.
- if {[regexp -- "^GDBtkInitVersion: (\[0-9\]+)\$" $line v]} {
+ if {[regexp -- "^# GDBtkInitVersion: (\[0-9\]+)\$" $line \
+ dummy v]} {
set version $v
}
}
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch: Fix .gdbtkinit reading
2001-08-21 14:39 Patch: Fix .gdbtkinit reading Tom Tromey
@ 2001-08-22 11:38 ` Keith Seitz
2001-08-22 11:43 ` Tom Tromey
2001-08-22 14:11 ` Tom Tromey
0 siblings, 2 replies; 6+ messages in thread
From: Keith Seitz @ 2001-08-22 11:38 UTC (permalink / raw)
To: Tom Tromey; +Cc: Insight List
On 21 Aug 2001, Tom Tromey wrote:
> Currently Insight tries to encode preference values which include `='.
> Unfortunately due to a small bug Insight doesn't properly re-read such
> values.
>
> I found this while trying to use a saved session. I tested the
> appended patch on that session. Ok to commit?
Looks pretty innocent to me. Did this fix your session problem, or do you
still need someone to look at it?
Keith
> Index: ChangeLog
> from Tom Tromey <tromey@redhat.com>
>
> * library/prefs.tcl (pref_read): Version number appears in
> comment.
>
> Index: library/prefs.tcl
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/prefs.tcl,v
> retrieving revision 1.11
> diff -u -r1.11 prefs.tcl
> --- library/prefs.tcl 2001/08/09 20:43:54 1.11
> +++ library/prefs.tcl 2001/08/21 21:39:37
> @@ -78,7 +78,8 @@
> {^[ \t\n]*#.*} {
> # Comment. We recognize one magic comment that includes
> # the version number.
> - if {[regexp -- "^GDBtkInitVersion: (\[0-9\]+)\$" $line v]} {
> + if {[regexp -- "^# GDBtkInitVersion: (\[0-9\]+)\$" $line \
> + dummy v]} {
> set version $v
> }
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch: Fix .gdbtkinit reading
2001-08-22 11:38 ` Keith Seitz
@ 2001-08-22 11:43 ` Tom Tromey
2001-08-22 12:01 ` Keith Seitz
2001-08-22 14:11 ` Tom Tromey
1 sibling, 1 reply; 6+ messages in thread
From: Tom Tromey @ 2001-08-22 11:43 UTC (permalink / raw)
To: Keith Seitz; +Cc: Insight List
Keith> Looks pretty innocent to me. Did this fix your session problem,
Keith> or do you still need someone to look at it?
Nope, this just fixed a reloading problem.
The other problem still exists.
I'd really like the eventual `insight' executable to have a different
command line than gdb. That way we can make it do more useful things.
What's the current scoop on the insight/gdb exe split?
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch: Fix .gdbtkinit reading
2001-08-22 11:43 ` Tom Tromey
@ 2001-08-22 12:01 ` Keith Seitz
0 siblings, 0 replies; 6+ messages in thread
From: Keith Seitz @ 2001-08-22 12:01 UTC (permalink / raw)
To: Tom Tromey; +Cc: Insight List
On 22 Aug 2001, Tom Tromey wrote:
> Keith> Looks pretty innocent to me. Did this fix your session problem,
> Keith> or do you still need someone to look at it?
>
> Nope, this just fixed a reloading problem.
> The other problem still exists.
> I'd really like the eventual `insight' executable to have a different
> command line than gdb. That way we can make it do more useful things.
> What's the current scoop on the insight/gdb exe split?
There was some discussion about how to do this: half the people wanted us
to create a file during the build with "int use_windows=1;" in it. The
other half wanted to tweak top.c to do something with ifdefs. Both are
kinda evil, but...
I'll try to instigate something on the gdb list.
Keith
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch: Fix .gdbtkinit reading
2001-08-22 11:38 ` Keith Seitz
2001-08-22 11:43 ` Tom Tromey
@ 2001-08-22 14:11 ` Tom Tromey
2001-08-22 15:26 ` Keith Seitz
1 sibling, 1 reply; 6+ messages in thread
From: Tom Tromey @ 2001-08-22 14:11 UTC (permalink / raw)
To: Keith Seitz; +Cc: Insight List
Tom> I found this while trying to use a saved session. I tested the
Tom> appended patch on that session. Ok to commit?
Keith> Looks pretty innocent to me.
I took this as an `ok' and I've committed the patch.
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch: Fix .gdbtkinit reading
2001-08-22 14:11 ` Tom Tromey
@ 2001-08-22 15:26 ` Keith Seitz
0 siblings, 0 replies; 6+ messages in thread
From: Keith Seitz @ 2001-08-22 15:26 UTC (permalink / raw)
To: Tom Tromey; +Cc: Insight List
On 22 Aug 2001, Tom Tromey wrote:
> Tom> I found this while trying to use a saved session. I tested the
> Tom> appended patch on that session. Ok to commit?
>
> Keith> Looks pretty innocent to me.
>
> I took this as an `ok' and I've committed the patch.
Yes, indeed. I should learn to be more black-and-white on checkins.
Thanks.
Keith
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2001-08-22 15:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-08-21 14:39 Patch: Fix .gdbtkinit reading Tom Tromey
2001-08-22 11:38 ` Keith Seitz
2001-08-22 11:43 ` Tom Tromey
2001-08-22 12:01 ` Keith Seitz
2001-08-22 14:11 ` Tom Tromey
2001-08-22 15:26 ` Keith Seitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).