* Build gdbtk-bp.c get error @ 2010-04-02 5:57 Hui Zhu 2010-04-02 23:42 ` [PATCH] " Keith Seitz 0 siblings, 1 reply; 3+ messages in thread From: Hui Zhu @ 2010-04-02 5:57 UTC (permalink / raw) To: insight; +Cc: Keith Seitz gcc -g -O2 -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber -I../../src/gdb/gnulib -Ignulib -DMI_OUT=1 -DTUI=1 -DGDBTK -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Werror -c -o gdbtk-bp.o -MT gdbtk-bp.o -MMD -MP -MF .deps/gdbtk-bp.Tpo -I../../src/gdb/../libgui/src -I/home/teawater/gdb/cvs/src/tcl/generic -I/home/teawater/gdb/cvs/src/tk/generic -DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\" -DSRC_DIR=\"/home/teawater/gdb/cvs/src/gdb\" ../../src/gdb/gdbtk/generic/gdbtk-bp.c ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'gdb_get_breakpoint_info': ../../src/gdb/gdbtk/generic/gdbtk-bp.c:365: error: dereferencing pointer to incomplete type ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'gdb_get_tracepoint_info': ../../src/gdb/gdbtk/generic/gdbtk-bp.c:775: error: dereferencing pointer to incomplete type make[2]: *** [gdbtk-bp.o] Error 1 make[2]: Leaving directory `/home/teawater/gdb/cvs/bgdball/gdb' make[1]: *** [all-gdb] Error 2 make[1]: Leaving directory `/home/teawater/gdb/cvs/bgdball' make: *** [all] Error 2 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Re: Build gdbtk-bp.c get error 2010-04-02 5:57 Build gdbtk-bp.c get error Hui Zhu @ 2010-04-02 23:42 ` Keith Seitz 2010-04-06 6:09 ` Hui Zhu 0 siblings, 1 reply; 3+ messages in thread From: Keith Seitz @ 2010-04-02 23:42 UTC (permalink / raw) To: Hui Zhu; +Cc: insight [-- Attachment #1: Type: text/plain, Size: 741 bytes --] On 04/01/2010 10:56 PM, Hui Zhu wrote: > ../../src/gdb/gdbtk/generic/gdbtk-bp.c > ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'gdb_get_breakpoint_info': > ../../src/gdb/gdbtk/generic/gdbtk-bp.c:365: error: dereferencing > pointer to incomplete type > ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'gdb_get_tracepoint_info': > ../../src/gdb/gdbtk/generic/gdbtk-bp.c:775: error: dereferencing > pointer to incomplete type Gdb is up to it again... I've committed the attached patch to correct this. Keith ChangeLog 2010-04-02 Keith Seitz <keiths@redhat.com> * generic/gdbtk-bp.c (gdb_get_breakpoint_info): Use breakpoint_commands to access breakpoint commands. (gdb_get_tracepoint_info): Likewise for tracepoint actions. [-- Attachment #2: more-bp-command-tweaks.patch --] [-- Type: text/plain, Size: 1112 bytes --] Index: generic/gdbtk-bp.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-bp.c,v retrieving revision 1.35 diff -u -p -r1.35 gdbtk-bp.c --- generic/gdbtk-bp.c 30 Mar 2010 16:48:31 -0000 1.35 +++ generic/gdbtk-bp.c 2 Apr 2010 23:37:58 -0000 @@ -362,7 +362,7 @@ gdb_get_breakpoint_info (ClientData clie Tcl_NewIntObj (b->ignore_count)); Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr, - get_breakpoint_commands (b->commands ? b->commands->commands : NULL)); + get_breakpoint_commands ((breakpoint_commands (b)) ? breakpoint_commands (b) : NULL)); Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr, Tcl_NewStringObj (b->cond_string, -1)); @@ -772,7 +772,7 @@ gdb_get_tracepoint_info (ClientData clie action_list = Tcl_NewObj (); if (tp->commands != NULL) { - for (cl = tp->commands->commands; cl != NULL; cl = cl->next) + for (cl = breakpoint_commands (tp); cl != NULL; cl = cl->next) { Tcl_ListObjAppendElement (interp, action_list, Tcl_NewStringObj (cl->line, -1)); ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Re: Build gdbtk-bp.c get error 2010-04-02 23:42 ` [PATCH] " Keith Seitz @ 2010-04-06 6:09 ` Hui Zhu 0 siblings, 0 replies; 3+ messages in thread From: Hui Zhu @ 2010-04-06 6:09 UTC (permalink / raw) To: Keith Seitz; +Cc: insight My part is OK. Thanks Keith. Best regards, Hui On Sat, Apr 3, 2010 at 07:42, Keith Seitz <keiths@redhat.com> wrote: > On 04/01/2010 10:56 PM, Hui Zhu wrote: >> >> ../../src/gdb/gdbtk/generic/gdbtk-bp.c >> ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function >> 'gdb_get_breakpoint_info': >> ../../src/gdb/gdbtk/generic/gdbtk-bp.c:365: error: dereferencing >> pointer to incomplete type >> ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function >> 'gdb_get_tracepoint_info': >> ../../src/gdb/gdbtk/generic/gdbtk-bp.c:775: error: dereferencing >> pointer to incomplete type > > Gdb is up to it again... I've committed the attached patch to correct this. > > Keith > > ChangeLog > 2010-04-02 Keith Seitz <keiths@redhat.com> > > * generic/gdbtk-bp.c (gdb_get_breakpoint_info): Use > breakpoint_commands to access breakpoint commands. > (gdb_get_tracepoint_info): Likewise for tracepoint actions. > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-06 6:09 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2010-04-02 5:57 Build gdbtk-bp.c get error Hui Zhu 2010-04-02 23:42 ` [PATCH] " Keith Seitz 2010-04-06 6:09 ` Hui Zhu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).