[Bug java/20056] New: [4.0 regression] 'verification failed: incompatible type on stack' with --indirect-dispatch

[Bug java/20056] New: [4.0 regression] 'verification failed: incompatible type on stack' with --indirect-dispatch

[bonniot at users dot sf dot net]

The testcase is a tiny bytecode class. gcj 3.3 and 3.4 can compile it, and the
bcel verifier says it is valid. However, gcj 4.0.0 fails on it when
--indirect-dispatch is enabled:

$ /usr/lib/gcc-snapshot/bin/gcj --indirect-dispatch test/ACatch.class
test/main.nice: In class 'test.ACatch':
test/main.nice: In constructor '(test.Monotype)':
test/main.nice:1: error: verification failed: incompatible type on stack

-- 
           Summary: [4.0 regression] 'verification failed: incompatible type
                    on stack' with --indirect-dispatch
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: java
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: bonniot at users dot sf dot net
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org
  GCC host triplet: i386-debian-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20056

[Bug java/20056] [4.0 regression] 'verification failed: incompatible type on stack' with --indirect-dispatch

[bonniot at users dot sf dot net]

------- Additional Comments From bonniot at users dot sf dot net  2005-02-18 14:53 -------
Created an attachment (id=8226)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8226&action=view)
testcase


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20056

[Bug java/20056] [4.0 regression] 'verification failed: incompatible type on stack' with --indirect-dispatch

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-02-18 22:00 -------
I'm looking at this


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |tromey at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-02-18 22:00:32
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20056

[Bug java/20056] [4.0 regression] 'verification failed: incompatible type on stack' with --indirect-dispatch

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-02-18 23:10 -------
There is a special case in "putfield" for setting a field
before the object reference has been initialized -- this is valid
in some cases.  This bug occurs because we aren't properly
checking all the preconditions of this special case.

I have a patch for gcc, I will write one for the runtime shortly.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20056

[Bug java/20056] [4.0 regression] 'verification failed: incompatible type on stack' with --indirect-dispatch

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-02-19 01:14 -------
Subject: Bug 20056

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tromey@gcc.gnu.org	2005-02-19 01:14:18

Modified files:
	gcc/java       : ChangeLog verify-glue.c verify-impl.c verify.h 

Log message:
	PR java/20056:
	* verify-glue.c (vfy_class_has_field): New function.
	* verify.h (vfy_class_has_field): Declare.
	* verify-impl.c (check_field_constant): Added 'putfield'
	argument.
	(verify_instructions_0): Updated.
	(types_equal): New function.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&r1=1.1552&r2=1.1553
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/verify-glue.c.diff?cvsroot=gcc&r1=1.3&r2=1.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/verify-impl.c.diff?cvsroot=gcc&r1=1.4&r2=1.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/verify.h.diff?cvsroot=gcc&r1=1.3&r2=1.4



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20056

[Bug java/20056] [4.0 regression] 'verification failed: incompatible type on stack' with --indirect-dispatch

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-02-19 01:16 -------
Subject: Bug 20056

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tromey@gcc.gnu.org	2005-02-19 01:16:30

Modified files:
	libjava        : ChangeLog link.cc verify.cc 
	libjava/include: jvm.h 

Log message:
	PR java/20056:
	* include/jvm.h (_Jv_Linker::has_field_p): Declare.
	* link.cc (has_field_p): New function.
	* verify.cc (check_field_constant): Added 'putfield' argument.
	(verify_instructions_0): Updated.
	(type::equals): New method.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3349&r2=1.3350
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/link.cc.diff?cvsroot=gcc&r1=1.8&r2=1.9
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/verify.cc.diff?cvsroot=gcc&r1=1.65&r2=1.66
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/include/jvm.h.diff?cvsroot=gcc&r1=1.76&r2=1.77



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20056

[Bug java/20056] [4.0 regression] 'verification failed: incompatible type on stack' with --indirect-dispatch

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-02-19 01:52 -------
I've checked in the fix for this.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20056

[Bug java/20056] [4.0 regression] 'verification failed: incompatible type on stack' with --indirect-dispatch

[bonniot at users dot sf dot net]

------- Additional Comments From bonniot at users dot sf dot net  2005-02-19 02:35 -------
Since bytecode classes cannot be put in the testsuite at the moment, here is a
Java source that, when first compiled to bytecode, exercises this bug during the
bytecode->native compilation, still with --indirect-dispatch.

class Field {
  int x;
  Field(int x) {}
  Field(Field f) {
    this(f.x = 0);
  }
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20056

[Bug java/20056] [4.0 regression] 'verification failed: incompatible type on stack' with --indirect-dispatch

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-02-19 03:57 -------
Subject: Bug 20056

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tromey@gcc.gnu.org	2005-02-19 03:57:21

Modified files:
	libjava        : ChangeLog verify.cc 
Added files:
	libjava/testsuite/libjava.lang: PR20056.java PR20056.out 

Log message:
	PR java/20056:
	* verify.cc (type::equals): Fixed test.
	* testsuite/libjava.lang/PR20056.out: New file.
	* testsuite/libjava.lang/PR20056.java: New file.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3351&r2=1.3352
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/verify.cc.diff?cvsroot=gcc&r1=1.66&r2=1.67
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.lang/PR20056.java.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/testsuite/libjava.lang/PR20056.out.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20056

[Bug java/20056] [4.0 regression] 'verification failed: incompatible type on stack' with --indirect-dispatch

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-02-19 04:02 -------
Subject: Bug 20056

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tromey@gcc.gnu.org	2005-02-19 04:02:10

Modified files:
	gcc/java       : ChangeLog verify-impl.c 

Log message:
	PR java/20056:
	* verify-impl.c (types_equal): Fixed test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&r1=1.1553&r2=1.1554
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/verify-impl.c.diff?cvsroot=gcc&r1=1.5&r2=1.6



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20056

[Bug java/20056] [4.0 regression] 'verification failed: incompatible type on stack' with --indirect-dispatch

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-02-22 18:14 -------
Subject: Bug 20056

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tromey@gcc.gnu.org	2005-02-22 18:14:04

Modified files:
	libjava        : ChangeLog verify.cc 

Log message:
	PR java/20056:
	* verify.cc (type::EITHER): New constant.
	(check_field_constant): Use it.
	(type::compatible): Handle it.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3379&r2=1.3380
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/verify.cc.diff?cvsroot=gcc&r1=1.67&r2=1.68



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20056

[Bug java/20056] [4.0 regression] 'verification failed: incompatible type on stack' with --indirect-dispatch

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-02-22 18:14 -------
Subject: Bug 20056

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tromey@gcc.gnu.org	2005-02-22 18:14:37

Modified files:
	gcc/java       : ChangeLog verify-impl.c 

Log message:
	PR java/20056:
	* verify-impl.c (EITHER): New define.
	(types_compatible): Handle it.
	(check_field_constant): Use it.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&r1=1.1554&r2=1.1555
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/verify-impl.c.diff?cvsroot=gcc&r1=1.6&r2=1.7



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20056

[Bug java/20056] [4.0 regression] 'verification failed: incompatible type on stack' with --indirect-dispatch

[bonniot at users dot sf dot net]

------- Additional Comments From bonniot at users dot sf dot net  2005-02-23 16:06 -------
I verified the bytecode testcase now passes.

Thanks for the fix! (is it final now?)

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20056