[Bug libgcj/20504] New: java.util.regex implementation doesn't support quoting constructs

[Bug libgcj/20504] New: java.util.regex implementation doesn't support quoting constructs

[overholt at redhat dot com]

This was originally filed in GNU Classpath's BTS, but it should probably be here
as well.

Ziga Mahkovec wrote there
(https://savannah.gnu.org/bugs/index.php?func=detailitem&item_id=12307):

We were recently having some problems with the search functionality in native
eclipse[1]. It boiled down to the lack of quoting regex constructs support in
gnu.regexp.RE (\Q, \E). A simple test:

Pattern.compile("\\Q" + "boo" + "\\E").matcher("Peekaboo").find();

returns false using classpath and true using java-sun.

I'm attaching a more comprehensive Mauve test for the java.util.regex
functionality. It consists of three test suites, adapted from PCRE[2] (which is
BSD licensed):

- testdata1: tests that are currently passed by classpath
- testdata2: tests that currently fail (disabled since they probably
need to be reviewed)
- testdata3: tests that use quoting constructs

I'm also attaching a tentative patch for the quoting constructs problem.

[1] https://bugzilla.redhat.com/beta/show_bug.cgi?id=149927
[2] http://www.pcre.org/

-- 
           Summary: java.util.regex implementation doesn't support quoting
                    constructs
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: overholt at redhat dot com
                CC: gcc-bugs at gcc dot gnu dot org,java-prs at gcc dot gnu
                    dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20504

[Bug libgcj/20504] java.util.regex implementation doesn't support quoting constructs

[overholt at redhat dot com]

------- Additional Comments From overholt at redhat dot com  2005-03-16 21:50 -------
Created an attachment (id=8406)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8406&action=view)
Patch for quoting constructs (from Ziga's CP bug)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20504

[Bug libgcj/20504] java.util.regex implementation doesn't support quoting constructs

[overholt at redhat dot com]

------- Additional Comments From overholt at redhat dot com  2005-03-16 21:51 -------
Created an attachment (id=8407)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8407&action=view)
Mauve test cases for java.util.regex (from Ziga's CP bug)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20504

[Bug libgcj/20504] java.util.regex implementation doesn't support quoting constructs

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2005-03-16 22:27 -------
The patch looks reasonable to me. Is the quoting feature something that should
be used in Perl style regular expressions as well, or is this a difference
between Perl-style and Java-style? If it is a difference, this feature should
only be enabled when RE_SYNTAX_JAVA_1_4 is enabled. 

Ziga, do you have a copyright assignment for GNU Classpath? This patch will need
a changelog entry, too?



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ziga dot mahkovec at klika
                   |                            |dot si
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-03-16 22:27:24
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20504

[Bug libgcj/20504] java.util.regex implementation doesn't support quoting constructs

[ziga dot mahkovec at klika dot si]

------- Additional Comments From ziga dot mahkovec at klika dot si  2005-03-17 00:33 -------
The quoting constructs are used in Perl as well [1]:
"\Q  quote (disable) pattern metacharacters till  \E"

I'm attaching the ChangeLog entry.  And my GNU Classpath copyright assignment is
in processing.

[1] http://www.perl.com/doc/manual/html/pod/perlre.html

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20504

[Bug libgcj/20504] java.util.regex implementation doesn't support quoting constructs

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2005-03-17 01:29 -------
Please make sure the ChangeLog is properly formatted. You're missing the name of
the changed method, and a "*" beside the filename. We're quite picky about this ;-)

Otherwise, the patch looks great. Please check it in once your assignment
paperwork is complete. Thanks!


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20504

[Bug libgcj/20504] java.util.regex implementation doesn't support quoting constructs

[mckinlay at redhat dot com]

------- Additional Comments From mckinlay at redhat dot com  2005-04-20 15:56 -------
Ziga, please let us know as soon as your FSF paperwork clears. Thanks!

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20504

[Bug libgcj/20504] java.util.regex implementation doesn't support quoting constructs

[ziga dot mahkovec at klika dot si]

------- Additional Comments From ziga dot mahkovec at klika dot si  2005-04-20 16:24 -------
Bryce,

about a month ago, I was informed that my papers were to be sent shortly.  I
forgot about it later, but I poked the copyright clerk now.

Let me know if there's anything I can do to speed things up (like putting the
patch in public domain for you to commit?).

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20504

[Bug libgcj/20504] java.util.regex implementation doesn't support quoting constructs

[overholt at redhat dot com]

------- Additional Comments From overholt at redhat dot com  2005-05-04 14:28 -------
Any news here?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20504

[Bug libgcj/20504] java.util.regex implementation doesn't support quoting constructs

[ziga dot mahkovec at klika dot si]

------- Additional Comments From ziga dot mahkovec at klika dot si  2005-05-04 15:01 -------
My copyright papers were resent and arrived successfully this time.  This was
about a week ago (and I returned them immediately) so I expect the confirmation
Real Soon Now.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20504

[Bug libgcj/20504] java.util.regex implementation doesn't support quoting constructs

[mark at gcc dot gnu dot org]

------- Additional Comments From mark at gcc dot gnu dot org  2005-05-16 16:03 -------
The paperwork cleared with the FSF.
There was a glitch in the new "fully-automatic" system.
Apologies.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20504

[Bug libgcj/20504] java.util.regex implementation doesn't support quoting constructs

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-05-16 19:02 -------
Subject: Bug 20504

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	tromey@gcc.gnu.org	2005-05-16 19:01:52

Modified files:
	libjava        : ChangeLog 
	libjava/gnu/regexp: RE.java 

Log message:
	2005-05-16  Ziga Mahkovec  <ziga.mahkovec@klika.si>
	
	PR libgcj/20504
	gnu/regexp/RE.java: Add support for quoting constructs.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3614&r2=1.3615
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/gnu/regexp/RE.java.diff?cvsroot=gcc&r1=1.3&r2=1.4



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20504

[Bug libgcj/20504] java.util.regex implementation doesn't support quoting constructs

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-05-16 19:03 -------
Subject: Bug 20504

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	tromey@gcc.gnu.org	2005-05-16 19:03:02

Modified files:
	libjava        : ChangeLog 
	libjava/gnu/regexp: RE.java 

Log message:
	2005-05-16  Ziga Mahkovec  <ziga.mahkovec@klika.si>
	
	PR libgcj/20504
	gnu/regexp/RE.java: Add support for quoting constructs.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.3391.2.66&r2=1.3391.2.67
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/gnu/regexp/RE.java.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.3&r2=1.3.2.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20504

[Bug libgcj/20504] java.util.regex implementation doesn't support quoting constructs

[tromey at gcc dot gnu dot org]

------- Additional Comments From tromey at gcc dot gnu dot org  2005-05-16 19:06 -------
I checked this in everywhere.
Thanks for taking the time to write the test cases, that is excellent.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.0.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20504

[Bug libgcj/20504] java.util.regex implementation doesn't support quoting constructs

[ziga dot mahkovec at klika dot si]

------- Additional Comments From ziga dot mahkovec at klika dot si  2005-05-16 19:18 -------
> I checked this in everywhere.

I was about to go through the procedure myself, but thanks anyway.
There was a typo in my initial ChangeLog entry though:

@@ -1,4 +1,4 @@
 2005-03-17  Ziga Mahkovec  <ziga.mahkovec@klika.si>

        PR libgcj/20504
-       gnu/regexp/RE.java: Add support for quoting constructs.
+       * gnu/regexp/RE.java: Add support for quoting constructs.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20504