[Bug java/52805] New: [4.8 Regression] 243 new GCC HEAD@185977 regressions (libjava failures)

[Bug java/52805] New: [4.8 Regression] 243 new GCC HEAD@185977 regressions (libjava failures)

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52805

             Bug #: 52805
           Summary: [4.8 Regression] 243 new GCC HEAD@185977 regressions
                    (libjava failures)
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: java
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dominiq@lps.ens.fr
                CC: hjl.tools@gmail.com, steven@gcc.gnu.org


Revision 185977:

Author:    steven
Date:    Thu Mar 29 21:00:23 2012 UTC (38 hours, 29 minutes ago)
Changed paths:    2
Log Message:    
    PR java/52730
    * class.c (emit_register_classes_in_jcr_section): New function.
    (emit_Jv_RegisterClass_calls): New function, split out from ...
    (emit_register_classes): ... here. Reorganize.  Do not call
    output_constant.

caused massive failures in the libjava test suite (see
http://gcc.gnu.org/ml/gcc-regression/2012-03/msg00282.html and the recent posts
at http://gcc.gnu.org/ml/gcc-regression/2012-03/ ).

[Bug java/52805] [4.8 Regression] 243 new GCC HEAD@185977 regressions (libjava failures)

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52805

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-03-31
                 CC|                            |iains at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #1 from Iain Sandoe <iains at gcc dot gnu.org> 2012-03-31 20:08:33 UTC ---
reverting the change does restore libjava function.

- I took a very quick look at the asm output from a "HelloWorld.class" (with
the patch in place) and it seems reasonable.  Presumably, some more complex
case (my example code only has one class) might be misrepresented.

[Bug java/52805] [4.8 Regression] 243 new GCC HEAD@185977 regressions (libjava failures)

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52805

--- Comment #2 from Iain Sandoe <iains at gcc dot gnu.org> 2012-04-01 17:28:47 UTC ---
I suspect you might have altered the priority of class discovery methods
inadvertently.

e.g. AFAICT, although darwin defines JCR_SECTION_NAME, there is no crt
machinery to deal with it [darwin has it's own crt code] - it's on my TODO to
look at that & confirm/deny/fix as appropriate.

not sure why i686-pc-linux is failing tho (since crtstuff does seem to have
provision for JCR - but not checked in any depth).

Darwin folks might like to try:

Index: gcc/config/darwin.h
===================================================================
--- gcc/config/darwin.h (revision 186018)
+++ gcc/config/darwin.h (working copy)
@@ -847,6 +847,7 @@ enum machopic_addr_class {

 /* Java runtime class list.  */
 #define JCR_SECTION_NAME "__DATA,jcr,regular,no_dead_strip"
+#define TARGET_USE_JCR_SECTION 0

 #undef ASM_PREFERRED_EH_DATA_FORMAT
 #define ASM_PREFERRED_EH_DATA_FORMAT(CODE,GLOBAL)  \

[Bug java/52805] [4.8 Regression] 243 new GCC HEAD@185977 regressions (libjava failures)

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52805

--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-04-01 22:30:33 UTC ---
Nice working patch! Though I doubt it'll work for linux;-) (both i686 and
x86_64).

        === libjava Summary for unix/-m64 ===

# of expected passes        2574

        === libjava Summary ===

# of expected passes        5148

[Bug java/52805] [4.8 Regression] 243 new GCC HEAD@185977 regressions (libjava failures)

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52805

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.8.0

--- Comment #4 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-04-02 09:14:35 UTC ---
I also see the issue, all runtime tests fail with OOM.

[Bug java/52805] [4.8 Regression] 243 new GCC HEAD@185977 regressions (libjava failures)

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52805

--- Comment #5 from Iain Sandoe <iains at gcc dot gnu.org> 2012-04-02 16:29:25 UTC ---
Rainer's commit (http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00031.html) fixes
this for i686-darwin9.

[Bug java/52805] [4.8 Regression] 243 new GCC HEAD@185977 regressions (libjava failures)

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52805

--- Comment #6 from Iain Sandoe <iains at gcc dot gnu.org> 2012-04-02 17:13:14 UTC ---
(In reply to comment #2)
> e.g. AFAICT, although darwin defines JCR_SECTION_NAME, there is no crt
> machinery to deal with it [darwin has it's own crt code]

JFTR (in case anyone else has gone looking for it),  there's no entry in the
Darwin system-provided crts for this, and we don't supply an FSF one for it
either - instead, it appears that the class init code is provided in
libgcj.dylib (from libjava/darwin.cc).

[Bug java/52805] [4.8 Regression] 243 new GCC HEAD@185977 regressions (libjava failures)

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52805

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-04-03 09:04:08 UTC ---
(In reply to comment #5)
> Rainer's commit (http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00031.html) fixes
> this for i686-darwin9.

Confirmed on x86_64-apple-darwin10 (without the patch in comment #2). Since it
is also fixed on the *86*-*-* platforms I have looked at, closing as fixed. If
there are other issues with darwin (comments #2 and #6), please open a new PR.