From: Mark Mitchell <mark@codesourcery.com>
To: Richard Henderson <rth@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
rguenther@suse.de, joseph@codesourcery.com, jason@redhat.com,
java@gcc.gnu.org, ian@airs.com, ebotcazou@libertysurf.fr
Subject: Re: [RFC] Centralize knowledge of eh personality routines
Date: Wed, 13 Oct 2010 14:14:00 -0000 [thread overview]
Message-ID: <4CB5BEB9.9000501@codesourcery.com> (raw)
In-Reply-To: <4CB4E841.1090308@redhat.com>
On 10/12/2010 3:59 PM, Richard Henderson wrote:
> The driver for this patch is SEH, which will add yet another function
> name variant in each of these places in each front end. While I could
> adjust each language appropriately, it seems to me that it is a bit
> cleaner to centralize this knowledge.
> Comments? Objections?
None in principle, but I think it would be better to have
build_personality_function take a language prefix string (e.g., "gxx" or
"gcj") rather than an enum. Logically, the middle-end shouldn't be
aware of what front-end languages exist, and passing in a string would
avoid that. And also avoid the tree.h -> dwarf2.h issue.
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
next prev parent reply other threads:[~2010-10-13 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 22:59 Richard Henderson
2010-10-13 1:11 ` Jason Merrill
2010-10-13 4:58 ` Ian Lance Taylor
2010-10-13 7:04 ` Eric Botcazou
2010-10-13 7:09 ` Arnaud Charlet
2010-10-13 7:23 ` Olivier Hainque
2010-10-13 8:53 ` Andrew Haley
2010-10-13 14:14 ` Mark Mitchell [this message]
2010-10-13 18:07 ` Richard Henderson
2010-10-13 18:12 ` Eric Botcazou
2010-10-13 18:26 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB5BEB9.9000501@codesourcery.com \
--to=mark@codesourcery.com \
--cc=ebotcazou@libertysurf.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=ian@airs.com \
--cc=jason@redhat.com \
--cc=java@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=rguenther@suse.de \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).