public inbox for java@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Haley <aph@redhat.com>
To: Richard Henderson <rth@redhat.com>
Cc: Dehao Chen <dehao@google.com>, Jason Merrill <jason@redhat.com>,
	       Richard Guenther <richard.guenther@gmail.com>,
	gcc-patches@gcc.gnu.org,        David Li <davidxl@google.com>,
	java@gcc.gnu.org
Subject: Re: [PATCH] Set correct source location for deallocator calls
Date: Thu, 30 Aug 2012 15:20:00 -0000	[thread overview]
Message-ID: <503F84A9.8010504@redhat.com> (raw)
In-Reply-To: <503F7876.7030606@redhat.com>

On 08/30/2012 03:28 PM, Richard Henderson wrote:
> On 08/17/2012 03:02 PM, Dehao Chen wrote:
>> I spend a whole day working on this, but find it very difficult to add
>> such a java test because:
>>
>> * First, libjava testsuits are all runtime tests, i.e., it compiles
>> the byte code to native code, execute it, and compares the output to
>> expected output. There is no way to scan the assembly.
>> * Though there is a way to derive the line number at runtime in java
>> (using Exception().getStackTrace()), this method only works on VM, and
>> the gcj generated native code does not get the lineno.
>>
>> Any suggestions on this?
> 
> Hmm, not from me, unfortunately.  Cc'ing the java list for clues.
> I won't hang up the main patch for this though.

Fair enough.  As Bryce said, line numbers should work if you have
addr2line installed.

Can't we scan the assembly?  Is the problem simply that the logic to
scan the assembly code isn't present in the libgcj testsuite?

Andrew.

  parent reply	other threads:[~2012-08-30 15:20 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAO2gOZXfnETUe4wqjT7p6fd61hXreu9PDfqKxNz+HxpE0E7K0g@mail.gmail.com>
     [not found] ` <CAO2gOZX_hZ1m0xKvxUg+6gWTOX4V5ok-vvCEg3Vhfpt=qXj8-g@mail.gmail.com>
     [not found]   ` <CAFiYyc00wud5Oa3k51ntm8KeZHZnfm4rpnBsOJjURZMcoqFdTA@mail.gmail.com>
     [not found]     ` <50228C38.5080703@redhat.com>
     [not found]       ` <CAO2gOZUbkTsnJ2fwgeNhcRmxkzzJEifECeiF=_YRUjeKDeRMdA@mail.gmail.com>
     [not found]         ` <502294A1.3060800@redhat.com>
     [not found]           ` <50243480.7090803@redhat.com>
     [not found]             ` <CAO2gOZURCuWUk2MVwCwmwrijNzWxJt3q=HUpU7=Qv6zB9e-uqA@mail.gmail.com>
     [not found]               ` <50254A50.8070208@redhat.com>
     [not found]                 ` <CAO2gOZXhHuFGJ0z=jvkYKZ84EoDaPSYVjxS7QzGore56SyhWyQ@mail.gmail.com>
     [not found]                   ` <50255B35.9020705@redhat.com>
     [not found]                     ` <CAO2gOZWe+qMrVyvOoo7Ek-di0NKZxxU4Z=pqrDCqqCCAfctZOw@mail.gmail.com>
     [not found]                       ` <50258712.4070002@redhat.com>
     [not found]                         ` <CAO2gOZUQQjmKtooyXXAfgFoNVbeNwtT+P=E7pQ6jC=e07Nsr2g@mail.gmail.com>
     [not found]                           ` <CAO2gOZX-Gn+b6LEzps5zxhgmwQWcJ-zFqG=a7hesW6fbVyxZYQ@mail.gmail.com>
     [not found]                             ` <502E6774.8050609@redhat.com>
     [not found]                               ` <CAO2gOZWhueDAShNLbNcJpkHA6QqXk1LNZhEMFvfT77aTZTCH9w@mail.gmail.com>
2012-08-30 14:28                                 ` Richard Henderson
2012-08-30 14:45                                   ` Bryce McKinlay
2012-08-30 15:20                                   ` Andrew Haley [this message]
2012-08-30 16:33                                     ` Richard Henderson
2012-09-04 16:07                                       ` Dehao Chen
2012-09-04 16:22                                         ` Andrew Haley
2012-09-04 20:40                                           ` Dehao Chen
2012-09-04 16:32                                         ` Bryce McKinlay
2012-09-04 16:40                                           ` Andrew Haley
2012-09-04 17:08                                             ` Bryce McKinlay
2012-09-04 17:12                                               ` Andrew Haley
2012-09-04 17:17                                                 ` Bryce McKinlay
2012-09-04 17:21                                                   ` Andrew Haley
2012-09-04 20:32                                                     ` Dehao Chen
2012-09-05  7:29                                                       ` Andrew Haley
2012-09-05  7:31                                                         ` Andrew Pinski
2012-09-05  9:58                                                   ` Mark Wielaard
2012-09-08 21:42                                                     ` Dehao Chen
2012-09-14 15:14                                                       ` Dehao Chen
2012-09-14 15:20                                                       ` Andrew Haley
2012-09-15  4:25                                                       ` H.J. Lu
2012-09-15  4:27                                                         ` Andrew Pinski
2012-09-15 12:55                                                           ` H.J. Lu
2012-09-15 16:09                                                             ` Dehao Chen
2012-09-15 18:06                                                               ` H.J. Lu
2012-09-15 22:03                                                                 ` Dehao Chen
2012-09-15 22:31                                                                   ` Mark Wielaard
2012-09-15 22:39                                                               ` Mark Wielaard
2012-09-15  4:27                                                         ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503F84A9.8010504@redhat.com \
    --to=aph@redhat.com \
    --cc=davidxl@google.com \
    --cc=dehao@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=java@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).