From: David Malcolm <dmalcolm@redhat.com>
To: jakub@redhat.com, Richard Biener <rguenther@suse.de>
Cc: FX <fxcoudert@gmail.com>,
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
gcc patches <gcc-patches@gcc.gnu.org>,
jit@gcc.gnu.org
Subject: Seeking Release Manager approval for: [PATCH] jit: fix link on OS X and Solaris (PR jit/64089 and PR jit/84288)
Date: Mon, 01 Jan 2018 00:00:00 -0000 [thread overview]
Message-ID: <1520604853.2913.118.camel@redhat.com> (raw)
In-Reply-To: <7D041128-A426-4B64-A0A2-8588B7F9984B@gmail.com>
On Wed, 2018-02-14 at 23:36 +0100, FX wrote:
> I can confirm that, with the attached revised patch, a bootstrap with
> --enable-languages=c,c++,jit --enable-host-shared is successful on
> macOS.
>
> FX
Looks good to me; thanks for fixing.
Release managers:
I'd like to apply FX's patch here:
https://gcc.gnu.org/ml/gcc-patches/2018-02/msg00881/patch
to trunk, to fix the build of jit on OS X, and to make it easier to fix
it on Solaris.
This involves touching gcc/configure.ac (and configure).
I've successfully bootstrapped and regression-tested it on x86_64-pc-
linux-gnu. FX reports above that it fixes the build on macOS, and
Rainer has an (untested) patch on top of it that ought to fix the build
on Solaris:
https://gcc.gnu.org/ml/gcc-patches/2018-02/msg00835.html
We're in stage 4, and the two bugs in question:
PR jit/64089 ("libgccjit.so.0.0.1 linkage failure on darwin")
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64089
PR jit/84288 ("Support jit on Solaris")
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84288
aren't regressions.
However, I believe this is a low-risk patch, and is mostly confined to
jit (and those targets).
Is it OK for trunk now, or does this need to wait until next stage 1?
Thanks
Dave
next prev parent reply other threads:[~2018-03-09 14:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <78D7B2DA-5677-4211-9C4E-F7B1B5AB51B5@gmail.com>
2018-01-01 0:00 ` David Malcolm
2018-01-01 0:00 ` Rainer Orth
2018-01-01 0:00 ` Rainer Orth
2018-01-01 0:00 ` FX
2018-01-01 0:00 ` FX
2018-01-01 0:00 ` David Malcolm [this message]
2018-01-01 0:00 ` Seeking Release Manager approval for: " Rainer Orth
2018-01-01 0:00 ` David Malcolm
2018-01-01 0:00 ` Rainer Orth
2018-01-01 0:00 ` David Malcolm
2018-01-01 0:00 ` Richard Biener
2018-01-01 0:00 ` Jakub Jelinek
2018-01-01 0:00 ` FX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520604853.2913.118.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=fxcoudert@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jit@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).