From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: David Malcolm <dmalcolm@redhat.com>
Cc: FX <fxcoudert@gmail.com>, gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: [PATCH] jit: fix link on OS X and Solaris (PR jit/64089 and PR jit/84288)
Date: Mon, 01 Jan 2018 00:00:00 -0000 [thread overview]
Message-ID: <yddk1vf4rs8.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <ydd1shovapv.fsf@CeBiTec.Uni-Bielefeld.DE> (Rainer Orth's message of "Tue, 13 Feb 2018 22:30:36 +0100")
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
Hi David,
>> * added LD_SONAME_OPTION, done in the same way
[...]
>> Does this fix the jit linker issues on OS X and Solaris?
>
> I'll give it a whirl tomorrow, including the jit-recording.c part of my
> patch to allow the build to complete.
actually, I've replaced the Makefile and configure parts of my patch
with yours and did a jit-only bootstrap on i386-pc-solaris2.11 with
as/ld and gas/ld. Both went fine with a minor caveat: I noticed that
LD_SONAME_OPTION wasn't set in gcc/Makefile. Fixed with the following
(so far untested) snippet:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: lso.patch --]
[-- Type: text/x-patch, Size: 521 bytes --]
diff --git a/gcc/configure.ac b/gcc/configure.ac
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -3715,6 +3715,12 @@ elif test x$gcc_cv_ld != x; then
gcc_cv_ld_soname=yes
ld_soname_option='-install_name'
;;
+ # Solaris 2 ld always supports -h. It also supports --soname for GNU
+ # ld compatiblity since some Solaris 10 update.
+ *-*-solaris2*)
+ gcc_cv_ld_soname=yes
+ ld_soname_option='-h'
+ ;;
esac
fi
# Don't AC_DEFINE result, only used in jit/Make-lang.in so far.
[-- Attachment #3: Type: text/plain, Size: 301 bytes --]
I've also checked that the original Solaris 10 release didn't support ld
-soname, so it's safer to always use the Solaris-native -h option
instead.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2018-02-14 13:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <78D7B2DA-5677-4211-9C4E-F7B1B5AB51B5@gmail.com>
2018-01-01 0:00 ` David Malcolm
2018-01-01 0:00 ` Rainer Orth
2018-01-01 0:00 ` Rainer Orth [this message]
2018-01-01 0:00 ` FX
2018-01-01 0:00 ` FX
2018-01-01 0:00 ` Seeking Release Manager approval for: " David Malcolm
2018-01-01 0:00 ` Jakub Jelinek
2018-01-01 0:00 ` Rainer Orth
2018-01-01 0:00 ` David Malcolm
2018-01-01 0:00 ` Rainer Orth
2018-01-01 0:00 ` David Malcolm
2018-01-01 0:00 ` Richard Biener
2018-01-01 0:00 ` FX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddk1vf4rs8.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=dmalcolm@redhat.com \
--cc=fxcoudert@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).