From: Richard Biener <rguenther@suse.de>
To: David Malcolm <dmalcolm@redhat.com>
Cc: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
jakub@redhat.com, FX <fxcoudert@gmail.com>,
gcc patches <gcc-patches@gcc.gnu.org>,
jit@gcc.gnu.org
Subject: Re: Seeking Release Manager approval for: [PATCH] jit: fix link on OS X and Solaris (PR jit/64089 and PR jit/84288)
Date: Mon, 01 Jan 2018 00:00:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.20.1803210921440.18265@zhemvz.fhfr.qr> (raw)
In-Reply-To: <1521589387.5688.38.camel@redhat.com>
On Tue, 20 Mar 2018, David Malcolm wrote:
> On Wed, 2018-03-21 at 00:39 +0100, Rainer Orth wrote:
> > Hi Malcolm,
> >
> > > > I've now tested the patch (together with the one from PR
> > > > jit/84288
> > > > for
> > > > several remaining issues). I've needed another snippet for
> > > > Solaris/SPARC which links libkstat into xgcc and needs it in
> > > > libgccjit.so, too. Bootstrapped without regressions on
> > > > i386-pc-solaris2.11 and sparc-sun-solaris2.11.
> > >
> > > FWIW I've successfully tested this on x86_64-pc-linux-gnu
> > > (regenerating
> > > the gcc/configure), and, as jit maintainer, it looks good to me
> > > [1],
> > > though it may still need RM approval given stage 4.
> >
> > thanks for trying this.
> >
> > > [1] ...though I have a slight preference for listing
> > > $(EXTRA_GCC_LIBS) on the same line as $(EXTRA_GCC_OBJS) in
> > > jit/Make-
> > > lang.in, so that these two items needed to embed the driver code
> > > into
> > > the libgccjit shared library are visually grouped together.
> >
> > I've selected the location of $(EXTRA_GCC_LIBS) in the link line to
> > match what gcc/Makefile.in does for xgcc etc.
>
> Indeed, I don't want to bikeshed it - I care much more about whether it
> works ;)
I'm fine with this patch.
Richard.
next prev parent reply other threads:[~2018-03-21 8:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <78D7B2DA-5677-4211-9C4E-F7B1B5AB51B5@gmail.com>
2018-01-01 0:00 ` David Malcolm
2018-01-01 0:00 ` Rainer Orth
2018-01-01 0:00 ` Rainer Orth
2018-01-01 0:00 ` FX
2018-01-01 0:00 ` FX
2018-01-01 0:00 ` Seeking Release Manager approval for: " David Malcolm
2018-01-01 0:00 ` Rainer Orth
2018-01-01 0:00 ` David Malcolm
2018-01-01 0:00 ` Rainer Orth
2018-01-01 0:00 ` David Malcolm
2018-01-01 0:00 ` Richard Biener [this message]
2018-01-01 0:00 ` Jakub Jelinek
2018-01-01 0:00 ` FX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1803210921440.18265@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=dmalcolm@redhat.com \
--cc=fxcoudert@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jit@gcc.gnu.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).