From: Jeff Law <jeffreyalaw@gmail.com>
To: Antoni Boucher <bouanto@zoho.com>,
jit@gcc.gnu.org, gcc-patches@gcc.gnu.org
Cc: David Malcolm <dmalcolm@redhat.com>
Subject: Re: [PATCH] libgccjit Fix a RTL bug for libgccjit
Date: Fri, 17 Nov 2023 14:06:40 -0700 [thread overview]
Message-ID: <7c598b42-f866-4661-8682-818e7e7bbccf@gmail.com> (raw)
In-Reply-To: <d7ffe995942c43dd8f462b16d234e475a73e4e86.camel@zoho.com>
On 11/16/23 15:36, Antoni Boucher wrote:
> Hi.
> This patch fixes a RTL bug when using some target-specific builtins in
> libgccjit (bug 112576).
>
> The test use a function from an unmerged patch:
> https://gcc.gnu.org/pipermail/jit/2023q1/001605.html
>
> Thanks for the review!
The natural question here is why does libgccjit call init_emit_once more
than one time? The whole point of that routine is doing one time
initializations. It's not supposed to be called more than once.
David? Thoughts here?
jeff
next prev parent reply other threads:[~2023-11-17 21:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 22:36 Antoni Boucher
2023-11-17 21:06 ` Jeff Law [this message]
2023-11-17 21:08 ` Antoni Boucher
2023-11-17 21:09 ` Jeff Law
2023-11-20 22:46 ` David Malcolm
2023-11-20 23:38 ` Jeff Law
2023-11-20 23:54 ` David Malcolm
2023-12-11 16:06 ` Jeff Law
2024-01-10 14:47 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c598b42-f866-4661-8682-818e7e7bbccf@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=bouanto@zoho.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).