From: Gerald Pfeifer <gerald@pfeifer.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: Pedro Alves <palves@redhat.com>,
Bernd Schmidt <bschmidt@redhat.com>,
Trevor Saunders <tbsaunde@tbsaunde.org>,
gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: [wwwdocs, coding conventions] Mention OVERRIDE/FINAL
Date: Sun, 01 Jan 2017 00:00:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.20.1701221003420.3033@anthias.pfeifer.com> (raw)
In-Reply-To: <1476480483.10766.46.camel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
Hi David,
On Fri, 14 Oct 2016, David Malcolm wrote:
> I propose that we update our coding conventions to mention the OVERRIDE
> and FINAL macros in the paragraph that discusses virtual funcs.
>
> The attached patch (to the website) does so.
>
> OK to commit?
I saw that Pedro agreed, but none of our global reviewers (such as
Bernd) chimed in.
So, while this looks fine from a pure wwwdocs perspective, I did
not feel comfortable approving it without larger concensus. If
you want to push this, perhaps send a note/request to gcc@ proposing
this?
Gerald
[-- Attachment #2: Type: text/x-patch, Size: 814 bytes --]
Index: htdocs/codingconventions.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/codingconventions.html,v
retrieving revision 1.77
diff -u -p -r1.77 codingconventions.html
--- htdocs/codingconventions.html 18 Sep 2016 13:55:17 -0000 1.77
+++ htdocs/codingconventions.html 14 Oct 2016 21:22:44 -0000
@@ -902,7 +902,10 @@ Its use with data-carrying classes is mo
<p>
Think carefully about the size and performance impact
of virtual functions and virtual bases
-before using them.
+before using them. If you do use virtual functions, use the
+<code>OVERRIDE</code> and <code>FINAL</code> macros from
+<code>include/ansidecl.h</code> to annotate the code for a human reader,
+and to allow sufficiently modern C++ compilers to detect mistakes.
</p>
<p>
next prev parent reply other threads:[~2017-01-22 9:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 0:00 [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h David Malcolm
2016-01-01 0:00 ` Pedro Alves
2016-01-01 0:00 ` Pedro Alves
2016-01-01 0:00 ` Trevor Saunders
2016-01-01 0:00 ` Move OVERRIDE/FINAL from gcc/coretypes.h to include/ansidecl.h (was: Re: [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h) Pedro Alves
2016-01-01 0:00 ` Move OVERRIDE/FINAL from gcc/coretypes.h to include/ansidecl.h Bernd Schmidt
2016-01-01 0:00 ` Pedro Alves
2016-01-01 0:00 ` Bernd Schmidt
2016-01-01 0:00 ` Pedro Alves
2016-01-01 0:00 ` [wwwdocs, coding conventions] Mention OVERRIDE/FINAL David Malcolm
2016-01-01 0:00 ` Pedro Alves
2017-01-01 0:00 ` Gerald Pfeifer
2017-01-01 0:00 ` Trevor Saunders
2017-01-01 0:00 ` Gerald Pfeifer [this message]
2016-01-01 0:00 ` [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h Pedro Alves
2016-01-01 0:00 ` Jason Merrill
2016-01-01 0:00 ` Jakub Jelinek
2016-01-01 0:00 ` CONSTEXPR macro (was "Re: [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h") David Malcolm
2016-01-01 0:00 ` Jakub Jelinek
2016-01-01 0:00 ` [PATCH 2/2] jit: use FINAL and OVERRIDE throughout David Malcolm
2016-01-01 0:00 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1701221003420.3033@anthias.pfeifer.com \
--to=gerald@pfeifer.com \
--cc=bschmidt@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=palves@redhat.com \
--cc=tbsaunde@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).