* [PATCH] libgccjit: update some comments in libgccjit.c
@ 2020-08-19 7:24 Andrea Corallo
2020-08-21 12:04 ` David Malcolm
0 siblings, 1 reply; 3+ messages in thread
From: Andrea Corallo @ 2020-08-19 7:24 UTC (permalink / raw)
To: jit, gcc-patches; +Cc: David Malcolm, nd
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
Hi all,
just a small patch updating some comments that apparently went out of
sync a while ago adding gcc_jit_context_new_rvalue_from_long.
Okay for trunk?
Thanks
Andrea
[-- Attachment #2: 0001-libgccjit-Update-comments-for-gcc_jit_context_new_rv.patch --]
[-- Type: text/plain, Size: 2417 bytes --]
From 84b94a039d164878bdbf8bfd1a2038960f813c76 Mon Sep 17 00:00:00 2001
From: Andrea Corallo <andrea.corallo@arm.com>
Date: Thu, 6 Aug 2020 10:25:40 +0200
Subject: [PATCH] libgccjit: Update comments for
gcc_jit_context_new_rvalue_from* functions
2020-08-06 Andrea Corallo <andrea.corallo@arm.com>
* libgccjit.c:
(gcc_jit_context_new_rvalue_from_int)
(gcc_jit_context_new_rvalue_from_long)
(gcc_jit_context_new_rvalue_from_double)
(gcc_jit_context_new_rvalue_from_ptr): Update function heading
comments.
---
gcc/jit/libgccjit.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/gcc/jit/libgccjit.c b/gcc/jit/libgccjit.c
index 3d04f6db3af..50130fbbe00 100644
--- a/gcc/jit/libgccjit.c
+++ b/gcc/jit/libgccjit.c
@@ -1188,7 +1188,7 @@ gcc_jit_rvalue_get_type (gcc_jit_rvalue *rvalue)
/* Public entrypoint. See description in libgccjit.h.
After error-checking, the real work is done by the
- gcc::jit::recording::context::new_rvalue_from_int method in
+ gcc::jit::recording::context::new_rvalue_from_const <int> method in
jit-recording.c. */
gcc_jit_rvalue *
@@ -1204,7 +1204,11 @@ gcc_jit_context_new_rvalue_from_int (gcc_jit_context *ctxt,
->new_rvalue_from_const <int> (numeric_type, value));
}
-/* FIXME. */
+/* Public entrypoint. See description in libgccjit.h.
+
+ After error-checking, the real work is done by the
+ gcc::jit::recording::context::new_rvalue_from_const <long> method
+ in jit-recording.c. */
gcc_jit_rvalue *
gcc_jit_context_new_rvalue_from_long (gcc_jit_context *ctxt,
@@ -1256,7 +1260,7 @@ gcc_jit_context_one (gcc_jit_context *ctxt,
/* Public entrypoint. See description in libgccjit.h.
After error-checking, the real work is done by the
- gcc::jit::recording::context::new_rvalue_from_double method in
+ gcc::jit::recording::context::new_rvalue_from_const <double> method in
jit-recording.c. */
gcc_jit_rvalue *
@@ -1275,8 +1279,8 @@ gcc_jit_context_new_rvalue_from_double (gcc_jit_context *ctxt,
/* Public entrypoint. See description in libgccjit.h.
After error-checking, the real work is done by the
- gcc::jit::recording::context::new_rvalue_from_ptr method in
- jit-recording.c. */
+ gcc::jit::recording::context::new_rvalue_from_const <void *> method
+ in jit-recording.c. */
gcc_jit_rvalue *
gcc_jit_context_new_rvalue_from_ptr (gcc_jit_context *ctxt,
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libgccjit: update some comments in libgccjit.c
2020-08-19 7:24 [PATCH] libgccjit: update some comments in libgccjit.c Andrea Corallo
@ 2020-08-21 12:04 ` David Malcolm
2020-08-22 7:52 ` Andrea Corallo
0 siblings, 1 reply; 3+ messages in thread
From: David Malcolm @ 2020-08-21 12:04 UTC (permalink / raw)
To: Andrea Corallo, jit, gcc-patches; +Cc: nd
On Wed, 2020-08-19 at 09:24 +0200, Andrea Corallo wrote:
> Hi all,
>
> just a small patch updating some comments that apparently went out of
> sync a while ago adding gcc_jit_context_new_rvalue_from_long.
> Okay for trunk?
Yes
Thanks for fixing these
Dave
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libgccjit: update some comments in libgccjit.c
2020-08-21 12:04 ` David Malcolm
@ 2020-08-22 7:52 ` Andrea Corallo
0 siblings, 0 replies; 3+ messages in thread
From: Andrea Corallo @ 2020-08-22 7:52 UTC (permalink / raw)
To: David Malcolm; +Cc: jit, gcc-patches, nd
David Malcolm <dmalcolm@redhat.com> writes:
> On Wed, 2020-08-19 at 09:24 +0200, Andrea Corallo wrote:
>> Hi all,
>>
>> just a small patch updating some comments that apparently went out of
>> sync a while ago adding gcc_jit_context_new_rvalue_from_long.
>
>> Okay for trunk?
>
> Yes
>
> Thanks for fixing these
> Dave
Pushed as fc34d04b075.
Thanks
Andrea
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-22 7:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19 7:24 [PATCH] libgccjit: update some comments in libgccjit.c Andrea Corallo
2020-08-21 12:04 ` David Malcolm
2020-08-22 7:52 ` Andrea Corallo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).