public inbox for
 help / color / mirror / Atom feed
From: Giuliano Procida <>
Subject: [PATCH 2/3] abidw: remove always true test in resolve_declaration_only_classes
Date: Thu, 25 Aug 2022 12:48:55 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

The code that makes the last attempt to resolve declaration-only types
was protected by a conditional checking that the number of TUs for a
given type was more than 1. The previous branch checked for exactly 1.
However, the entire block is inside a conditional where the number of
TUs is guaranteed to be greater than 0.

Removing the conditional makes it clear that this branch handles all
remaining cases.

	* src/
	(read_context::resolve_declaration_only_classes): Remove
	tautological conditional.

Signed-off-by: Giuliano Procida <>
 src/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ b/src/
index a954de6d..b5e60e35 100644
--- a/src/
+++ b/src/
@@ -4274,7 +4274,7 @@ public:
 		    else if (per_tu_class_map.size() == 1)
-		    else if (per_tu_class_map.size() > 1)
+		    else
 			// We are in case where there are more than
 			// one definition for the declaration.  Let's

  parent reply	other threads:[~2022-08-25 11:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-25 11:48 [PATCH 0/3] Improve resolution of declaration-only enums Giuliano Procida
2022-08-25 11:48 ` [PATCH 1/3] abidw: fix --stats output for resolved classes and enums Giuliano Procida
2022-08-29 11:19   ` Dodji Seketeli
2022-08-25 11:48 ` Giuliano Procida [this message]
2022-08-29 11:19   ` [PATCH 2/3] abidw: remove always true test in resolve_declaration_only_classes Dodji Seketeli
2022-08-25 11:48 ` [PATCH 3/3] abidw: resolve declaration-only enums the same as classes Giuliano Procida
2022-08-29 11:20   ` Dodji Seketeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).