Re: [PATCH] Add regression tests for abipkgdiff using ctf info

["Guillermo E. Martinez" <guillermo.e.martinez@oracle.com>]

On Friday, July 1, 2022 9:40:22 AM CDT Dodji Seketeli wrote:
> Hello Guillermo,
Hello Dodji,

> "Guillermo E. Martinez via Libabigail" <libabigail@sourceware.org> a
> écrit:
> 
> Thank you for working on this.  It's appreciated.
Thanks, 
> I have a question however.
> 
> [...]
> 
> > This patch implements the regression tests for abipkgdiff tool to help
> > process packages win ctf debug information.  Since the code shares
> > lots of functionalities already used with abipkgdiff in comparing
> > packages with dwarf info, a library was built.
> 
> I am wondering ...
> 
> [...]
> 
> > 	* tests/test-diff-pkg-ctf.cc: Testsuite for abipkgdiff --ctf.
> 
> Why come up with a something else but test-diff-pkg.cc just to test RPMs
> using abipkgdiff --ctf?
Actually that was my first approach, but looking inside of the acts to perform
the abipkgdiff DWARFs test, the steps could be changed in the feature
(new steps in `perform' member function applied to DWARFs not applicable to CTF),
so it was my motivation to split the tests. But of course these are my
thoughts, and I will follow you advices because you have much more
experience. So what do you think, worth split the tests for DWARF and CTF?
> I mean, can't we just use test-diff-pkg.cc and fill in entries made of
> instances of struct InOutSpec with InOutSpec::prog_option filled in with
> a string prefixed by " --ctf " ?
> 
> Of course, those ctf-related entries would be guarded by #ifdef WITH_CTF
> or the like.
> 
> 
> Wouldn't that work and be simpler?
For the current implementation, absolutely. 
> [...]
Regards,
guillermo