Re: [PATCH] Add regression tests for abipkgdiff using ctf info

[Dodji Seketeli <dodji@seketeli.org>]

Hello Guillermo,

"Guillermo E. Martinez via Libabigail" <libabigail@sourceware.org> a
écrit:

Thank you for working on this.  It's appreciated.

I have a question however.

[...]

> This patch implements the regression tests for abipkgdiff tool to help
> process packages win ctf debug information.  Since the code shares
> lots of functionalities already used with abipkgdiff in comparing
> packages with dwarf info, a library was built.

I am wondering ...

[...]

> 	* tests/test-diff-pkg-ctf.cc: Testsuite for abipkgdiff --ctf.

Why come up with a something else but test-diff-pkg.cc just to test RPMs
using abipkgdiff --ctf?

I mean, can't we just use test-diff-pkg.cc and fill in entries made of
instances of struct InOutSpec with InOutSpec::prog_option filled in with
a string prefixed by " --ctf " ?

Of course, those ctf-related entries would be guarded by #ifdef WITH_CTF
or the like.


Wouldn't that work and be simpler?

[...]

Cheers,

-- 
		Dodji