* [PATCH] abipkgdiff: remove unused includes of elfutils/libdw.h and elf.h
@ 2020-06-09 11:38 Matthias Maennich
2020-06-09 17:43 ` Giuliano Procida
2020-06-15 7:57 ` Dodji Seketeli
0 siblings, 2 replies; 3+ messages in thread
From: Matthias Maennich @ 2020-06-09 11:38 UTC (permalink / raw)
To: libabigail; +Cc: dodji, gprocida, kernel-team, maennich
Definitions from those headers are not actually used. Yet the includes
create unnecessary dependencies.
* tools/abipkgdiff.cc: Drop unused includes.
Signed-off-by: Matthias Maennich <maennich@google.com>
---
tools/abipkgdiff.cc | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/abipkgdiff.cc b/tools/abipkgdiff.cc
index 7d946e72b3c8..445e2406830b 100644
--- a/tools/abipkgdiff.cc
+++ b/tools/abipkgdiff.cc
@@ -72,8 +72,6 @@
#include <assert.h>
#include <fcntl.h>
#include <sys/stat.h>
-#include <elf.h>
-#include <elfutils/libdw.h>
// If fts.h is included before config.h, its indirect inclusions may
// not give us the right LFS aliases of these functions, so map them
--
2.27.0.278.ge193c7cf3a9-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] abipkgdiff: remove unused includes of elfutils/libdw.h and elf.h
2020-06-09 11:38 [PATCH] abipkgdiff: remove unused includes of elfutils/libdw.h and elf.h Matthias Maennich
@ 2020-06-09 17:43 ` Giuliano Procida
2020-06-15 7:57 ` Dodji Seketeli
1 sibling, 0 replies; 3+ messages in thread
From: Giuliano Procida @ 2020-06-09 17:43 UTC (permalink / raw)
To: Matthias Maennich; +Cc: libabigail, Dodji Seketeli, kernel-team
Hi.
On Tue, 9 Jun 2020 at 12:38, Matthias Maennich <maennich@google.com> wrote:
>
> Definitions from those headers are not actually used. Yet the includes
> create unnecessary dependencies.
>
> * tools/abipkgdiff.cc: Drop unused includes.
>
Reviewed-by: Giuliano Procida <gprocida@google.com>
> Signed-off-by: Matthias Maennich <maennich@google.com>
> ---
> tools/abipkgdiff.cc | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/abipkgdiff.cc b/tools/abipkgdiff.cc
> index 7d946e72b3c8..445e2406830b 100644
> --- a/tools/abipkgdiff.cc
> +++ b/tools/abipkgdiff.cc
> @@ -72,8 +72,6 @@
> #include <assert.h>
> #include <fcntl.h>
> #include <sys/stat.h>
> -#include <elf.h>
> -#include <elfutils/libdw.h>
>
> // If fts.h is included before config.h, its indirect inclusions may
> // not give us the right LFS aliases of these functions, so map them
> --
> 2.27.0.278.ge193c7cf3a9-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] abipkgdiff: remove unused includes of elfutils/libdw.h and elf.h
2020-06-09 11:38 [PATCH] abipkgdiff: remove unused includes of elfutils/libdw.h and elf.h Matthias Maennich
2020-06-09 17:43 ` Giuliano Procida
@ 2020-06-15 7:57 ` Dodji Seketeli
1 sibling, 0 replies; 3+ messages in thread
From: Dodji Seketeli @ 2020-06-15 7:57 UTC (permalink / raw)
To: Matthias Maennich; +Cc: libabigail, gprocida, kernel-team
Matthias Maennich <maennich@google.com> a écrit:
> Definitions from those headers are not actually used. Yet the includes
> create unnecessary dependencies.
>
> * tools/abipkgdiff.cc: Drop unused includes.
>
> Signed-off-by: Matthias Maennich <maennich@google.com>
Applied to master, thanks!
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-15 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-09 11:38 [PATCH] abipkgdiff: remove unused includes of elfutils/libdw.h and elf.h Matthias Maennich
2020-06-09 17:43 ` Giuliano Procida
2020-06-15 7:57 ` Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).