From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com,
maennich@google.com
Subject: Re: [PATCH] abg-dwarf-reader: Fix typo in compare_dies_string_attribute_value
Date: Tue, 09 Feb 2021 15:39:07 +0100 [thread overview]
Message-ID: <868s7xgvas.fsf@seketeli.org> (raw)
In-Reply-To: <20210208173146.391981-1-gprocida@google.com> (Giuliano Procida's message of "Mon, 8 Feb 2021 17:31:46 +0000")
Giuliano Procida <gprocida@google.com> a écrit:
> A recent commit to add DW_FORM_line_strp support had a small typo in
> an assertion. This commit corrects that.
>
> * src/abg-dwarf-reader.cc
> (compare_dies_string_attribute_value): Typo fix.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
> ---
> src/abg-dwarf-reader.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc
> index 810da2f2..9004ff13 100644
> --- a/src/abg-dwarf-reader.cc
> +++ b/src/abg-dwarf-reader.cc
> @@ -9446,7 +9446,7 @@ compare_dies_string_attribute_value(const Dwarf_Die *l, const Dwarf_Die *r,
> || r_attr.form == DW_FORM_string
> || r_attr.form == DW_FORM_GNU_strp_alt
> || form_is_DW_FORM_strx(r_attr.form)
> - || form_is_DW_FORM_line_strp(l_attr.form));
> + || form_is_DW_FORM_line_strp(r_attr.form));
>
> if ((l_attr.form == DW_FORM_strp
> && r_attr.form == DW_FORM_strp)
Applied to master, thanks!
Cheers,
--
Dodji
prev parent reply other threads:[~2021-02-09 14:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 17:31 Giuliano Procida
2021-02-09 14:39 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868s7xgvas.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).