* [PATCH] abg-dwarf-reader: Fix typo in compare_dies_string_attribute_value
@ 2021-02-08 17:31 Giuliano Procida
2021-02-09 14:39 ` Dodji Seketeli
0 siblings, 1 reply; 2+ messages in thread
From: Giuliano Procida @ 2021-02-08 17:31 UTC (permalink / raw)
To: libabigail; +Cc: dodji, kernel-team, gprocida, maennich
A recent commit to add DW_FORM_line_strp support had a small typo in
an assertion. This commit corrects that.
* src/abg-dwarf-reader.cc
(compare_dies_string_attribute_value): Typo fix.
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
src/abg-dwarf-reader.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc
index 810da2f2..9004ff13 100644
--- a/src/abg-dwarf-reader.cc
+++ b/src/abg-dwarf-reader.cc
@@ -9446,7 +9446,7 @@ compare_dies_string_attribute_value(const Dwarf_Die *l, const Dwarf_Die *r,
|| r_attr.form == DW_FORM_string
|| r_attr.form == DW_FORM_GNU_strp_alt
|| form_is_DW_FORM_strx(r_attr.form)
- || form_is_DW_FORM_line_strp(l_attr.form));
+ || form_is_DW_FORM_line_strp(r_attr.form));
if ((l_attr.form == DW_FORM_strp
&& r_attr.form == DW_FORM_strp)
--
2.30.0.478.g8a0d178c01-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] abg-dwarf-reader: Fix typo in compare_dies_string_attribute_value
2021-02-08 17:31 [PATCH] abg-dwarf-reader: Fix typo in compare_dies_string_attribute_value Giuliano Procida
@ 2021-02-09 14:39 ` Dodji Seketeli
0 siblings, 0 replies; 2+ messages in thread
From: Dodji Seketeli @ 2021-02-09 14:39 UTC (permalink / raw)
To: Giuliano Procida; +Cc: libabigail, kernel-team, maennich
Giuliano Procida <gprocida@google.com> a écrit:
> A recent commit to add DW_FORM_line_strp support had a small typo in
> an assertion. This commit corrects that.
>
> * src/abg-dwarf-reader.cc
> (compare_dies_string_attribute_value): Typo fix.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
> ---
> src/abg-dwarf-reader.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc
> index 810da2f2..9004ff13 100644
> --- a/src/abg-dwarf-reader.cc
> +++ b/src/abg-dwarf-reader.cc
> @@ -9446,7 +9446,7 @@ compare_dies_string_attribute_value(const Dwarf_Die *l, const Dwarf_Die *r,
> || r_attr.form == DW_FORM_string
> || r_attr.form == DW_FORM_GNU_strp_alt
> || form_is_DW_FORM_strx(r_attr.form)
> - || form_is_DW_FORM_line_strp(l_attr.form));
> + || form_is_DW_FORM_line_strp(r_attr.form));
>
> if ((l_attr.form == DW_FORM_strp
> && r_attr.form == DW_FORM_strp)
Applied to master, thanks!
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-09 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08 17:31 [PATCH] abg-dwarf-reader: Fix typo in compare_dies_string_attribute_value Giuliano Procida
2021-02-09 14:39 ` Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).