* [PATCH] ctf-reader: Remove useless parameter from fill_ctf_section
@ 2021-11-22 16:21 Dodji Seketeli
2021-11-22 18:23 ` Jose E. Marchesi
0 siblings, 1 reply; 2+ messages in thread
From: Dodji Seketeli @ 2021-11-22 16:21 UTC (permalink / raw)
To: libabigail
Hello,
While looking at something else, I noticed fill_ctf_section now has a
useless parameter that was making compiling with some "tight" options
cringe.
Fixed thus.
* src/abg-ctf-reader.cc (fill_ctf_section): Remove the now useless
context parameter. Adjust the comment accordingly.
(slurp_elf_info): Adjust the invocation of fill_ctf_section.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
src/abg-ctf-reader.cc | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc
index 2c2c204d..fd53f8a1 100644
--- a/src/abg-ctf-reader.cc
+++ b/src/abg-ctf-reader.cc
@@ -992,12 +992,11 @@ close_elf_handler (read_context *ctxt)
/// Fill a CTF section description with the information in a given ELF
/// section.
///
-/// @param ctxt the read context.
/// @param elf_section the ELF section from which to get.
/// @param ctf_section the CTF section to fill with the raw data.
static void
-fill_ctf_section(read_context *ctxt, Elf_Scn *elf_section, ctf_sect_t *ctf_section)
+fill_ctf_section(Elf_Scn *elf_section, ctf_sect_t *ctf_section)
{
GElf_Shdr section_header_mem, *section_header;
Elf_Data *section_data;
@@ -1046,9 +1045,9 @@ slurp_elf_info(read_context *ctxt, corpus_sptr corp)
if (ctf_scn == NULL || symtab_scn == NULL || strtab_scn == NULL)
return 0;
- fill_ctf_section(ctxt, ctf_scn, &ctxt->ctf_sect);
- fill_ctf_section(ctxt, symtab_scn, &ctxt->symtab_sect);
- fill_ctf_section(ctxt, strtab_scn, &ctxt->strtab_sect);
+ fill_ctf_section(ctf_scn, &ctxt->ctf_sect);
+ fill_ctf_section(symtab_scn, &ctxt->symtab_sect);
+ fill_ctf_section(strtab_scn, &ctxt->strtab_sect);
return 1;
}
--
2.33.1
--
Dodji
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ctf-reader: Remove useless parameter from fill_ctf_section
2021-11-22 16:21 [PATCH] ctf-reader: Remove useless parameter from fill_ctf_section Dodji Seketeli
@ 2021-11-22 18:23 ` Jose E. Marchesi
0 siblings, 0 replies; 2+ messages in thread
From: Jose E. Marchesi @ 2021-11-22 18:23 UTC (permalink / raw)
To: Dodji Seketeli via Libabigail; +Cc: Dodji Seketeli
> Hello,
>
> While looking at something else, I noticed fill_ctf_section now has a
> useless parameter that was making compiling with some "tight" options
> cringe.
>
> Fixed thus.
>
> * src/abg-ctf-reader.cc (fill_ctf_section): Remove the now useless
> context parameter. Adjust the comment accordingly.
> (slurp_elf_info): Adjust the invocation of fill_ctf_section.
>
> Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-22 18:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-22 16:21 [PATCH] ctf-reader: Remove useless parameter from fill_ctf_section Dodji Seketeli
2021-11-22 18:23 ` Jose E. Marchesi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).