From: Dodji Seketeli <dodji@seketeli.org>
To: Matthias Maennich <maennich@google.com>
Cc: libabigail@sourceware.org, gprocida@google.com,
kernel-team@android.com
Subject: Re: [PATCH 2/5] XML writer: use exemplar types for tracking referenced types
Date: Fri, 10 Dec 2021 11:42:23 +0100 [thread overview]
Message-ID: <87mtl8rbao.fsf@seketeli.org> (raw)
In-Reply-To: <20211203114622.2944173-3-maennich@google.com> (Matthias Maennich's message of "Fri, 3 Dec 2021 11:46:20 +0000")
Matthias Maennich <maennich@google.com> a écrit:
> The emitted type sets are used with some referenced type sets (which use
> bare type pointers). To keep consistency between what is being recorded
> in each set, switch to storing exemplar type pointers in the referenced
> type sets.
>
> This change results in the omission of a small number of duplicate
> types from various test cases. In each case the duplicates were
> previously caused by a referenced type being emitted for one
> translation unit and then the same type being emitted as a canonical
> type for a later translation unit.
>
> It also causes the movement of some function types in some test cases.
> Some of those types are now considered referenced and appear earlier as
> a result.
>
> * src/abg-writer.cc (record_type_as_referenced): Use preferred
> type with referenced type sets.
> (type_is_referenced): Likewise.
> (tests/data/test-annotate/test14-pr18893.so.abi): Duplicate
> type(s) removed, as described above.
> (tests/data/test-read-dwarf/test14-pr18893.so.abi): Likewise.
> (tests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.abi):
> Likewise.
> (tests/data/test-read-dwarf/test16-pr18904.so.abi): Likewise.
> (tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi):
> Likewise.
> (tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi):
> Likewise.
> (tests/data/test-read-dwarf/PR25007-sdhci.ko.abi): Some
> function type(s) reordered, as described above.
> (tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi):
> Likewise.
> (tests/data/test-annotate/test15-pr18892.so.abi):: Duplicate
> type(s) removed and some function type(s) reordered, as
> described above.
> (tests/data/test-read-dwarf/test15-pr18892.so.abi): Likewise.
> (tests/data/test-annotate/test21-pr19092.so.abi): Likewise.
> (tests/data/test-read-dwarf/test21-pr19092.so.abi): Likewise
>
> Reviewed-by: Giuliano Procida <gprocida@google.com>
> Signed-off-by: Matthias Maennich <maennich@google.com>
Applied to master, thanks!
[...]
Cheers,
--
Dodji
next prev parent reply other threads:[~2021-12-10 10:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 11:46 [PATCH 0/5] Improvements for the XML Writer Matthias Maennich
2021-12-03 11:46 ` [PATCH 1/5] XML writer: use consistent type pointers for type ids and emission tracking Matthias Maennich
2021-12-09 17:57 ` Dodji Seketeli
2021-12-03 11:46 ` [PATCH 2/5] XML writer: use exemplar types for tracking referenced types Matthias Maennich
2021-12-10 10:42 ` Dodji Seketeli [this message]
2021-12-03 11:46 ` [PATCH 3/5] XML writer: track emitted types by bare pointer Matthias Maennich
2021-12-10 10:50 ` Dodji Seketeli
2021-12-16 16:07 ` Matthias Maennich
2022-01-10 17:00 ` Dodji Seketeli
2022-01-17 18:03 ` Matthias Maennich
2022-01-18 17:15 ` Dodji Seketeli
2021-12-03 11:46 ` [PATCH 4/5] XML writer: map type ids " Matthias Maennich
2022-01-19 10:12 ` Dodji Seketeli
2021-12-03 11:46 ` [PATCH 5/5] XML writer: resolve declaration-only enum definitions Matthias Maennich
2022-01-19 10:38 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtl8rbao.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).