From: Dodji Seketeli <dodji@seketeli.org>
To: Matthias Maennich <maennich@google.com>
Cc: libabigail@sourceware.org, gprocida@google.com,
kernel-team@android.com
Subject: Re: [PATCH 4/5] XML writer: map type ids by bare pointer
Date: Wed, 19 Jan 2022 11:12:42 +0100 [thread overview]
Message-ID: <87sftkavad.fsf@seketeli.org> (raw)
In-Reply-To: <20211203114622.2944173-5-maennich@google.com> (Matthias Maennich's message of "Fri, 3 Dec 2021 11:46:22 +0000")
Matthias Maennich <maennich@google.com> a écrit:
> This is a performance and safety improvement made possible by previous
> changes which ensure that the same pointers are used for insertion and
> look-up.
>
> This change affects two test cases. In more detail:
>
> The test case test-read-dwarf/PR22122-libftdc.so.abi has many
> duplicate type-id-60 which appear to all be types defined with a DWARF
> DW_AT_signature attribute. These are made into separate types by this
> change, but remain incomplete.
>
> The test case test-read-dwarf/PR25007-sdhci.ko.abi has duplicate
> declarations and these get split into duplicate declarations with new
> type ids following this change. The test suite runs with an implicit
> --no-linux-kernel-mode so the duplicates are treated separately. They
> presumably had the same type ids before this change due to deep
> equality considering them equal.
>
> * src/abg-writer.cc (type_ptr_map): use default equality on
> type_base pointer.
> * tests/data/test-read-dwarf/PR22122-libftdc.so.abi: Refresh
> test case, as described above.
> * tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Likewise.
>
> Reviewed-by: Giuliano Procida <gprocida@google.com>
> Signed-off-by: Matthias Maennich <maennich@google.com>
Applied to master, thanks!
[...]
Cheers,
--
Dodji
next prev parent reply other threads:[~2022-01-19 10:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 11:46 [PATCH 0/5] Improvements for the XML Writer Matthias Maennich
2021-12-03 11:46 ` [PATCH 1/5] XML writer: use consistent type pointers for type ids and emission tracking Matthias Maennich
2021-12-09 17:57 ` Dodji Seketeli
2021-12-03 11:46 ` [PATCH 2/5] XML writer: use exemplar types for tracking referenced types Matthias Maennich
2021-12-10 10:42 ` Dodji Seketeli
2021-12-03 11:46 ` [PATCH 3/5] XML writer: track emitted types by bare pointer Matthias Maennich
2021-12-10 10:50 ` Dodji Seketeli
2021-12-16 16:07 ` Matthias Maennich
2022-01-10 17:00 ` Dodji Seketeli
2022-01-17 18:03 ` Matthias Maennich
2022-01-18 17:15 ` Dodji Seketeli
2021-12-03 11:46 ` [PATCH 4/5] XML writer: map type ids " Matthias Maennich
2022-01-19 10:12 ` Dodji Seketeli [this message]
2021-12-03 11:46 ` [PATCH 5/5] XML writer: resolve declaration-only enum definitions Matthias Maennich
2022-01-19 10:38 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sftkavad.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).