* [PATCH] Fix fedabipkgdiff configure check for Python 3.12
@ 2023-07-07 18:01 Yaakov Selkowitz
2023-07-10 7:42 ` Dodji Seketeli
0 siblings, 1 reply; 2+ messages in thread
From: Yaakov Selkowitz @ 2023-07-07 18:01 UTC (permalink / raw)
To: libabigail
importlib is the Python 3 replacement to imp, which was deprecated in
Python 3.4 and removed in 3.12.
* configure.ac (REQUIRED_PYTHON_MODULES_FOR_FEDABIPKGDIFF):
Test for importlib.machinery instead of imp with python3.
Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
---
configure.ac | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index b4e7e38e..b3f97ba2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -739,13 +739,15 @@ if test x$CHECK_DEPS_FOR_FEDABIPKGDIFF = xyes; then
# urllib.parse. Oh well.
if test x$PYTHON = xpython3; then
URLPARSE_MODULE=urllib.parse
+ IMPORT_MODULE=importlib.machinery
else
URLPARSE_MODULE=urlparse
+ IMPORT_MODULE=imp
fi
REQUIRED_PYTHON_MODULES_FOR_FEDABIPKGDIFF="\
argparse logging os re subprocess sys $URLPARSE_MODULE \
- xdg koji mock rpm imp tempfile mimetypes shutil six"
+ xdg koji mock rpm $IMPORT_MODULE tempfile mimetypes shutil six"
AX_CHECK_PYTHON_MODULES([$REQUIRED_PYTHON_MODULES_FOR_FEDABIPKGDIFF],
[$PYTHON],
--
2.41.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix fedabipkgdiff configure check for Python 3.12
2023-07-07 18:01 [PATCH] Fix fedabipkgdiff configure check for Python 3.12 Yaakov Selkowitz
@ 2023-07-10 7:42 ` Dodji Seketeli
0 siblings, 0 replies; 2+ messages in thread
From: Dodji Seketeli @ 2023-07-10 7:42 UTC (permalink / raw)
To: Yaakov Selkowitz via Libabigail; +Cc: Yaakov Selkowitz
Hello Yaakov,
Yaakov Selkowitz via Libabigail <libabigail@sourceware.org> a écrit:
> importlib is the Python 3 replacement to imp, which was deprecated in
> Python 3.4 and removed in 3.12.
>
> * configure.ac (REQUIRED_PYTHON_MODULES_FOR_FEDABIPKGDIFF):
> Test for importlib.machinery instead of imp with python3.
>
> Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
Applied to the master branch, thanks!
[...]
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-10 7:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-07 18:01 [PATCH] Fix fedabipkgdiff configure check for Python 3.12 Yaakov Selkowitz
2023-07-10 7:42 ` Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).