From: Dodji Seketeli <dodji@redhat.com>
To: libabigail@sourceware.org
Subject: [PATCH, applied] ir: remove redundant cycle detection code in equals
Date: Mon, 10 Oct 2022 13:57:38 +0200 [thread overview]
Message-ID: <87tu4b28nh.fsf@redhat.com> (raw)
Hello,
While looking at something else, I realized that in the overload for
the equals() function for class_or_union, the cycle detection
management code was redundant for the case where we are looking
comparing a decl-only class to another class.
This patch removes that redundant code.
* src/abg-ir.cc (equals): In the overload for class_or_union
remove redundant cycle detection code when comparison a decl-only
class to another class.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
src/abg-ir.cc | 4 ----
1 file changed, 4 deletions(-)
diff --git a/src/abg-ir.cc b/src/abg-ir.cc
index 2cb74339..e6b8409a 100644
--- a/src/abg-ir.cc
+++ b/src/abg-ir.cc
@@ -22240,10 +22240,6 @@ equals(const class_or_union& l, const class_or_union& r, change_kind* k)
}
}
- RETURN_TRUE_IF_COMPARISON_CYCLE_DETECTED(l, r);
-
- mark_types_as_being_compared(l, r);
-
bool val = *def1 == *def2;
if (!val)
if (k)
--
2.38.0.rc2
--
Dodji
reply other threads:[~2022-10-10 11:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu4b28nh.fsf@redhat.com \
--to=dodji@redhat.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).