From: Trilok Soni <quic_tsoni@quicinc.com>
To: Giuliano Procida <gprocida@google.com>, <quic_johmoo@quicinc.com>
Cc: <masahiroy@kernel.org>, <nathan@kernel.org>,
<ndesaulniers@google.com>, <nicolas@fjasle.eu>,
<linux-kbuild@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>, <gregkh@linuxfoundation.org>,
<rdunlap@infradead.org>, <arnd@arndb.de>, <andersson@kernel.org>,
<tkjos@google.com>, <maennich@google.com>,
<kernel-team@android.com>, <libabigail@sourceware.org>,
<jorcrous@amazon.com>, <quic_satyap@quicinc.com>,
<quic_eberman@quicinc.com>, <quic_gurus@quicinc.com>
Subject: Re: [PATCH] scripts/check-uapi.sh: add stgdiff support
Date: Sat, 22 Jul 2023 12:40:51 -0700 [thread overview]
Message-ID: <a19818a4-3457-7362-4deb-b981fdc9ba84@quicinc.com> (raw)
In-Reply-To: <20230720161053.1213680-1-gprocida@google.com>
On 7/20/2023 9:10 AM, Giuliano Procida wrote:
> Hi John.
>
> I spent a few minutes adding stgdiff support to the script. It's
> really just for illustration purposes.
>
> As I think you know, STG doesn't yet exist as a project outside of
> AOSP. Nevertheless, this may be useful to you as-is.
>
> STG has quite a different philosophy to libabigil in terms of
> filtering out certain kinds of differences. Some of the things (like
> enum enumerator additions) are not considered harmless. The reasoning
> behind this is basically...
> https://en.wikipedia.org/wiki/Covariance_and_contravariance_(computer_science)
>
> However, it does have --ignore interface_addition (and the related
> --ignore type_definition_addition) which can be used to detect whether
> one ABI is a subset of another.
>
> I am looking at adding support for macro definitions (gcc -g3) to STG
> which will then let us cover significantly more of the UAPI surface.
>
> Unfortunately, there are some headers which use anonymous enums to
> define constants (e.g. and ironically BTF). ABI tracking these types
> would require something a bit hacky. Or we could just name them.
Thank you Giuliano for trying the script w/ stg. We will review the
modifications below.
Just to update everyone here that John is looking into the libabigail
changes to reduce the false positives as discussed earlier in the email
thread. There is some progress on the libabigail mailing list. Once we
have enough changes made in the libabigail, John will update here with
his results.
We have also submitted abstract in LPC 2023 Android MC as well about the
UAPI checker. We hope to make a good progress before LPC.
---Trilok Soni
next prev parent reply other threads:[~2023-07-22 19:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 20:34 [PATCH v5 0/2] Validating UAPI backwards compatibility John Moon
2023-04-07 20:34 ` [PATCH v5 1/2] check-uapi: Introduce check-uapi.sh John Moon
2023-04-10 10:03 ` Masahiro Yamada
2023-04-10 18:45 ` Greg Kroah-Hartman
2023-04-10 23:32 ` John Moon
2023-04-11 6:34 ` Greg Kroah-Hartman
2023-04-11 18:36 ` John Moon
2023-04-12 6:14 ` Greg Kroah-Hartman
2023-04-12 16:37 ` John Moon
2023-04-12 16:43 ` Greg Kroah-Hartman
2023-04-13 17:07 ` John Moon
2023-04-13 18:22 ` Greg Kroah-Hartman
2023-04-13 14:37 ` Mark Wielaard
2023-04-13 17:12 ` Giuliano Procida
2023-04-13 17:15 ` John Moon
2023-04-13 17:03 ` Nicolas Schier
2023-04-13 17:33 ` John Moon
2023-07-20 16:10 ` [PATCH] scripts/check-uapi.sh: add stgdiff support Giuliano Procida
2023-07-22 19:40 ` Trilok Soni [this message]
2023-04-07 20:34 ` [PATCH v5 2/2] docs: dev-tools: Add UAPI checker documentation John Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a19818a4-3457-7362-4deb-b981fdc9ba84@quicinc.com \
--to=quic_tsoni@quicinc.com \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=gprocida@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jorcrous@amazon.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maennich@google.com \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=quic_eberman@quicinc.com \
--cc=quic_gurus@quicinc.com \
--cc=quic_johmoo@quicinc.com \
--cc=quic_satyap@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).