[Bug default/26261] New: compare_dies contains some useless code

[Bug default/26261] New: compare_dies contains some useless code

[gprocida+abigail at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26261

            Bug ID: 26261
           Summary: compare_dies contains some useless code
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: gprocida+abigail at google dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 12707
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12707&action=edit
one line patch

The attached patch changes an instance of "result = true" to
"ABG_ASSERT(result)" in compare_dies. The existing statement is useless.

This may point to some unintended or incomplete behaviour. The patch has a few
more details.

Regards,
Giuliano.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26261] compare_dies contains some useless code

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26261

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2020-07-30
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26261] unfinished handling of comparing DW_TAG_subroutine_type DIEs in compare_dies

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26261

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|compare_dies contains some  |unfinished handling of
                   |useless code                |comparing
                   |                            |DW_TAG_subroutine_type DIEs
                   |                            |in compare_dies

--- Comment #1 from dodji at redhat dot com ---
Yes, you are right.  That denotes some unfinished code there.

The intent was to safely detect when we could get out early and not proceed to
the full potentially slow structural comparison.  So essentially what is
missing there is a "break" statement, I think.

I am coming up with a patch to finish that part of the code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26261] unfinished handling of comparing DW_TAG_subroutine_type DIEs in compare_dies

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26261

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from dodji at redhat dot com ---
This commit, applied to master should hopefully address the issue you raised:

https://sourceware.org/git/?p=libabigail.git;a=commit;h=817a2755bce057efa47aa5ceda78e7fbe1658faa.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.