[Bug default/26591] detect pathologically redundant types in abixml

["gprocida+abigail at google dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=26591

Giuliano Procida <gprocida+abigail at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gprocida+abigail at google dot com

--- Comment #2 from Giuliano Procida <gprocida+abigail at google dot com> ---
This relates to current master, commit
8ae8dcb8d5b87dafd0b9fdd716654e4bf3284c95.

Looking for duplicate type ids in ABI XML (ignoring subranges)...

find tests -name '*.abi' -or -name '*.xml' | while read f; do <"$f" fgrep -v
'<subrange ' | sed -rn "s;.* id='([^']*)'.*;\1;p" | sort | uniq -c | sed 's;^
*;;' | grep -vw "^1" | sed "s;^;$f:;"; done

There are lots of duplicates (and exactly 2 of each type id seems to be a
common pattern). I saw one case where "void" type-id-4 had been emitted several
times.

However, duplicate type-ids being defined non-identically is a bit more serious
and we've noticed this in an internal bug report. Maybe canonicalisation has
gone wrong, the type definitions should have been merged, or some type elements
are just being emitted in the wrong places.

tests/data/test-read-dwarf/test12-pr18844.so.abi type-id-3888 (6 definitions)
is an example of this.

There seems to be a separate issue with anonymous types and duplicate type ids.
There are two identical definitions of type-id-2652 in
tests/data/test-diff-suppr/test45-abi.xml. However, they are contained in
(presumably identical) anonymous unions that have been given different internal
names.

-- 
You are receiving this mail because:
You are on the CC list for the bug.