public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "gprocida+abigail at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/26591] detect pathologically redundant types in abixml
Date: Sat, 20 Mar 2021 10:32:27 +0000	[thread overview]
Message-ID: <bug-26591-9487-KnkvEchjME@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-26591-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=26591

--- Comment #6 from Giuliano Procida <gprocida+abigail at google dot com> ---
One of the worst cases of duplicate type ids being used for different types
(genuinely different it seems, not fragments of each other) is type-id-60 in
tests/data/test-read-dwarf/PR22122-libftdc.so.

This is a snippet of abidw tests/data/test-read-dwarf/PR22122-libftdc.so |
c++filt.

      <class-decl name='__anonymous_struct__' is-anonymous='yes'
visibility='default' is-declaration-only='yes' id='type-id-60'>
        <member-function access='public'>
          <function-decl name='intrusive_ptr'
mangled-name='boost::intrusive_ptr<mongo::SharedBuffer::Holder>::intrusive_ptr()'
filepath='src/third_party/boost-1.60.0/boost/smart_ptr/intrusive_ptr.hpp'
line='62' column='1' visibility='default' binding='global' size-in-bits='64'>
            <parameter type-id='type-id-63' is-artificial='yes'/>
            <return type-id='type-id-26'/>
          </function-decl>
        </member-function>
        <member-function access='public' destructor='yes'>
          <function-decl name='~intrusive_ptr'
mangled-name='boost::intrusive_ptr<mongo::SharedBuffer::Holder>::~intrusive_ptr()'
filepath='src/third_party/boost-1.60.0/boost/smart_ptr/intrusive_ptr.hpp'
line='95' column='1' visibility='default' binding='global' size-in-bits='64'>
            <parameter type-id='type-id-63' is-artificial='yes'/>
            <return type-id='type-id-26'/>
          </function-decl>
        </member-function>
      </class-decl>
      <class-decl name='__anonymous_struct__1' is-anonymous='yes'
visibility='default' is-declaration-only='yes' id='type-id-60'>
        <member-type access='private'>
          <typedef-decl name='rval_reference_type' type-id='type-id-152'
filepath='src/third_party/boost-1.60.0/boost/optional/optional.hpp' line='777'
column='1' id='type-id-153'/>
        </member-type>
        <member-function access='public'>
          <function-decl name='optional'
mangled-name='boost::optional<std::vector<mongo::BSONObj,
std::allocator<mongo::BSONObj> > >::optional()'
filepath='src/third_party/boost-1.60.0/boost/optional/optional.hpp' line='786'
column='1' visibility='default' binding='global' size-in-bits='64'>
            <parameter type-id='type-id-63' is-artificial='yes'/>
            <return type-id='type-id-26'/>
          </function-decl>
        </member-function>
        <member-function access='public'>
          <function-decl name='optional'
mangled-name='boost::optional<mongo::FTDCBSONUtil::FTDCType>::optional(mongo::FTDCBSONUtil::FTDCType&&)'
filepath='src/third_party/boost-1.60.0/boost/optional/optional.hpp' line='799'
column='1' visibility='default' binding='global' size-in-bits='64'>
            <parameter type-id='type-id-63' is-artificial='yes'/>
            <parameter type-id='type-id-153'/>
            <return type-id='type-id-26'/>
          </function-decl>
        </member-function>
      </class-decl>

Both are anonymous, declaration-only classes but contain member functions that
clearly belong to named, defined templated types.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-03-20 10:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 15:18 [Bug default/26591] New: " dodji at redhat dot com
2020-09-09 15:18 ` [Bug default/26591] " dodji at redhat dot com
2020-09-10 13:56 ` dodji at redhat dot com
2021-03-02 15:31 ` gprocida+abigail at google dot com
2021-03-05 16:58 ` gprocida+abigail at google dot com
2021-03-05 17:09 ` gprocida+abigail at google dot com
2021-03-05 17:15 ` gprocida+abigail at google dot com
2021-03-20 10:32 ` gprocida+abigail at google dot com [this message]
2021-03-31 16:40 ` gprocida+abigail at google dot com
2021-04-06 20:56 ` gprocida+abigail at google dot com
2021-04-06 21:24 ` gprocida+abigail at google dot com
2021-08-12 22:09 ` gprocida at google dot com
2021-12-01 10:19 ` maennich at android dot com
2021-12-03  9:38 ` mark at klomp dot org
2021-12-03 10:25 ` gprocida at google dot com
2022-07-08 11:13 ` gprocida at google dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-26591-9487-KnkvEchjME@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).