From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/26591] detect pathologically redundant types in abixml
Date: Fri, 08 Jul 2022 11:13:24 +0000 [thread overview]
Message-ID: <bug-26591-9487-ricbjto1wi@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-26591-9487@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=26591
--- Comment #14 from gprocida at google dot com ---
I made a tiny start on this:
static Dwarf_Die*
check_signature(Dwarf_Die* die, Dwarf_Die* signature_die)
{
Dwarf_Attribute attr;
return die && dwarf_attr_integrate(die, DW_AT_signature, &attr)
&& dwarf_formref_die(&attr, signature_die) ? signature_die : die;
}
and then in build_ir_node_from_die:
Dwarf_Die signature;
die = check_signature(die, &signature);
However, it breaks assumptions about canonical DIEs. Or at least, I get
assertion failures in compute_canonical_die:
ABG_ASSERT(dwarf_offdie(dwarf_per_die_source(source), die_offset, &die));
--
You are receiving this mail because:
You are on the CC list for the bug.
prev parent reply other threads:[~2022-07-08 11:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 15:18 [Bug default/26591] New: " dodji at redhat dot com
2020-09-09 15:18 ` [Bug default/26591] " dodji at redhat dot com
2020-09-10 13:56 ` dodji at redhat dot com
2021-03-02 15:31 ` gprocida+abigail at google dot com
2021-03-05 16:58 ` gprocida+abigail at google dot com
2021-03-05 17:09 ` gprocida+abigail at google dot com
2021-03-05 17:15 ` gprocida+abigail at google dot com
2021-03-20 10:32 ` gprocida+abigail at google dot com
2021-03-31 16:40 ` gprocida+abigail at google dot com
2021-04-06 20:56 ` gprocida+abigail at google dot com
2021-04-06 21:24 ` gprocida+abigail at google dot com
2021-08-12 22:09 ` gprocida at google dot com
2021-12-01 10:19 ` maennich at android dot com
2021-12-03 9:38 ` mark at klomp dot org
2021-12-03 10:25 ` gprocida at google dot com
2022-07-08 11:13 ` gprocida at google dot com [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-26591-9487-ricbjto1wi@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).