[Bug default/27165] New: abidiff fails with error: Assertion `__abg_cond__' failed.

[Bug default/27165] New: abidiff fails with error: Assertion `__abg_cond__' failed.

[thomas.barbier at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27165

            Bug ID: 27165
           Summary: abidiff fails with error: Assertion `__abg_cond__'
                    failed.
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: thomas.barbier at gmail dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Hi,

I have an issue with abidiff (tested with version 1.6.0 and 1.7.2).
It fails with the following error:
abidiff: ../../src/abg-dwarf-reader.cc:13077: void
abigail::dwarf_reader::finish_member_function_reading(Dwarf_Die*, const
function_decl_sptr&, const class_or_union_sptr&,
abigail::dwarf_reader::read_context&): Assertion `__abg_cond__' failed.
Aborted

How to reproduce the issue:

# Get reproducer.tar.gz from the attachment
tar -xzvf reproducer.tar.gz
abidiff --no-unreferenced-symbols --headers-dir1 old/include/ --headers-dir2
new/include/ old/lib/libzmq.so new/lib/libzmq.so

Let me know if you need more information.

Cheers
Thomas

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27165] abidiff fails with error: Assertion `__abg_cond__' failed.

[thomas.barbier at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27165

--- Comment #1 from Thomas Barbier <thomas.barbier at gmail dot com> ---
Created attachment 13106
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13106&action=edit
old folder containing old headers and lib

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27165] abidiff fails with error: Assertion `__abg_cond__' failed.

[thomas.barbier at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27165

--- Comment #2 from Thomas Barbier <thomas.barbier at gmail dot com> ---
Created attachment 13107
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13107&action=edit
new tarball contianing new headers and lib (being compared by abidiff against
old)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27165] abidiff fails with error: Assertion `__abg_cond__' failed.

[thomas.barbier at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27165

--- Comment #3 from Thomas Barbier <thomas.barbier at gmail dot com> ---
Update to reproducer as I didn't manage to upload reproducer.tar.gz:

How to reproduce the issue:

# Get old.tar.gz and new.tar.gz from the attachments
tar -xzvf old.tar.gz
tar -xzvf new.tar.gz
abidiff --no-unreferenced-symbols --headers-dir1 old/include/ --headers-dir2
new/include/ old/lib/libzmq.so new/lib/libzmq.so

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27165] abidiff fails with error: Assertion `__abg_cond__' failed.

[maennich at android dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27165

Matthias Maennich <maennich at android dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2021-01-08
                 CC|                            |maennich at android dot com

--- Comment #4 from Matthias Maennich <maennich at android dot com> ---
Thanks for taking the time to report this.
Meanwhile, libabigail 1.8 has been released with a ton of fixes and
improvements:
https://sourceware.org/pipermail/libabigail/2020q4/002957.html

Would you mind testing with the latest release, please?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27165] abidiff fails with error: Assertion `__abg_cond__' failed.

[thomas.barbier at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27165

--- Comment #5 from Thomas Barbier <thomas.barbier at gmail dot com> ---
Hi,

I just tested this morning with libabigail 1.8.0 and I have the same issue:

$ ~/local/bin/abidiff --version
/home/thomas/local/bin/abidiff: 1.8.0
$ ~/local/bin/abidiff --no-unreferenced-symbols --headers-dir1 old/include/
--headers-dir2 new/include/ old/lib/libzmq.so new/lib/libzmq.so
abidiff: abg-dwarf-reader.cc:12498: abigail::ir::scope_decl_sptr
abigail::dwarf_reader::get_scope_for_die(abigail::dwarf_reader::read_context&,
Dwarf_Die*, bool, size_t): Assertion `__abg_cond__' failed.
Aborted

It seems the issue is still there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27165] abidiff fails with error: Assertion `__abg_cond__' failed.

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27165

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27165] Better support multi-language binaries

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27165

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|abidiff fails with error:   |Better support
                   |Assertion `__abg_cond__'    |multi-language binaries
                   |failed.                     |
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from dodji at redhat dot com ---
This should be fixed by commit
https://sourceware.org/git/?p=libabigail.git;a=commit;h=271e3afaf6f2b6f38b4f125f64f5b24a8f78459f
in the master branch.

This fix should be available in the 2.0 version of libabigail.

-- 
You are receiving this mail because:
You are on the CC list for the bug.