public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/28320] abidw - (non-deterministic) infinite loop in XML writer
Date: Tue, 14 Sep 2021 16:54:46 +0000	[thread overview]
Message-ID: <bug-28320-9487-5dRSwmensA@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28320-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28320

--- Comment #6 from gprocida at google dot com ---
I've debugged the issue I see with the test suite (with the debugging patches I
posted active).

The triggering command is:

build/tools/abipkgdiff --verbose --self-check --d1
tests/data/test-diff-pkg/nmap-debuginfo-7.70-5.el8_testjcc.x86_64.rpm --d2
tests/data/test-diff-pkg/nmap-debuginfo-7.70-5.el8_testjcc.x86_64.rpm
tests/data/test-diff-pkg/nmap-7.70-5.el8_testjcc.x86_64.rpm
tests/data/test-diff-pkg/nmap-7.70-5.el8_testjcc.x86_64.rpm

It triggers on "struct lua_State". The type already in the map (already
emitted) is declaration only with no named_definition_of_declaration while the
other is a canonical type (get_naked_canonical_type gives the same pointer).

Tracing through what the deep_ptr_eq_functor does:

The first type is a class_decl, as is the second, and end we up in
equals(class_decl, class_decl). One of them is declaration only, so this
function delegates to equals(class_or_union, class_or_union). One of the types
is declaration only, neither are anonymous and ODR is relevant, so equality
checks the scoped names.

The scoped names are identical and equality evaluates to true.

On the other hand, the hash values are completely different.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2021-09-14 16:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09  9:30 [Bug default/28320] New: " gprocida at google dot com
2021-09-09  9:44 ` [Bug default/28320] " gprocida at google dot com
2021-09-09 12:30 ` gprocida at google dot com
2021-09-13 10:23 ` dodji at redhat dot com
2021-09-13 15:12 ` dodji at redhat dot com
2021-09-13 20:09 ` gprocida at google dot com
2021-09-14 16:54 ` gprocida at google dot com [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28320-9487-5dRSwmensA@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).