public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/28320] abidw - (non-deterministic) infinite loop in XML writer
Date: Mon, 13 Sep 2021 10:23:21 +0000	[thread overview]
Message-ID: <bug-28320-9487-u5UJgROkmO@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28320-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28320

--- Comment #3 from dodji at redhat dot com ---
Hello,

I couldn't reproduce this issue on the branch you mentioned, while compiling
libabigail with gcc.

However, I tried punching in the dark a little bit.

Could you please try this patch and see if it as an impact at all?

diff --git a/src/abg-writer.cc b/src/abg-writer.cc
index 9f48dc92..46b6d456 100644
--- a/src/abg-writer.cc
+++ b/src/abg-writer.cc
@@ -2356,7 +2356,8 @@ write_translation_unit(write_context&             ctxt,
          // considered "opaque".
          if (class_decl_sptr class_type = is_class_type(t))
            if (class_type->get_is_declaration_only()
-               && !ctxt.type_is_emitted(class_type))
+               && !ctxt.type_is_emitted(class_type)
+               && !ctxt.decl_only_type_is_emitted(class_type))
              write_type(class_type, ctxt,
                         indent + c.get_xml_element_indent());
          continue;

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-09-13 10:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09  9:30 [Bug default/28320] New: " gprocida at google dot com
2021-09-09  9:44 ` [Bug default/28320] " gprocida at google dot com
2021-09-09 12:30 ` gprocida at google dot com
2021-09-13 10:23 ` dodji at redhat dot com [this message]
2021-09-13 15:12 ` dodji at redhat dot com
2021-09-13 20:09 ` gprocida at google dot com
2021-09-14 16:54 ` gprocida at google dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28320-9487-u5UJgROkmO@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).