public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/28320] New: abidw - (non-deterministic) infinite loop in XML writer
Date: Thu, 09 Sep 2021 09:30:48 +0000	[thread overview]
Message-ID: <bug-28320-9487@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=28320

            Bug ID: 28320
           Summary: abidw - (non-deterministic) infinite loop in XML
                    writer
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: gprocida at google dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 13659
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13659&action=edit
compressed library file

libabigail version:

https://android.googlesource.com/platform/external/libabigail/+/4e975fe2bc039f3354fd7bb3df0ea9ed289fda40

This corresponds roughly to current master
190350a35f842574cf15b9a98f1ccbc3aa31a840. However, there are some minor
differences. None currently in the XML writer or IR.

$ git diff --stat aosp/upstream-master HEAD include src tools
 include/abg-comparison.h  |    6 +
 include/abg-version.h     |    8 +
 src/abg-comparison-priv.h |    2 +
 src/abg-comparison.cc     |   16 ++
 src/abg-config.cc         |    9 +
 src/abg-leaf-reporter.cc  |   55 ++++-
 src/abg-reader.cc         |   54 ++--
 src/abg-reporter-priv.cc  |   88 ++-----
 src/abg-reporter-priv.h   |    2 +-
 src/abg-tools-utils.cc    |   11 +-
 tools/Makefile.am         |    8 +-
 tools/abidiff.cc          |    9 +-
 tools/abitidy.cc          | 1428
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 13 files changed, 1577 insertions(+), 119 deletions(-)

More significantly, abidw and its dependencies are compiled within a
standardised Android build environment (Clang, compile flags, libc++ etc.).

With the attached file, libc.so, about 4% of

abidw libc.so --out-file /dev/null

invocations result in an infinite loop.

The line

    <class-decl name='DIR' is-struct='yes' visibility='default'
is-declaration-only='yes' id='type-id-1114'/>

is emitted in a tight loop.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2021-09-09  9:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09  9:30 gprocida at google dot com [this message]
2021-09-09  9:44 ` [Bug default/28320] " gprocida at google dot com
2021-09-09 12:30 ` gprocida at google dot com
2021-09-13 10:23 ` dodji at redhat dot com
2021-09-13 15:12 ` dodji at redhat dot com
2021-09-13 20:09 ` gprocida at google dot com
2021-09-14 16:54 ` gprocida at google dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28320-9487@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).