[Bug default/29300] New: btrfs-progs fails self-compare only on ppc64le

[Bug default/29300] New: btrfs-progs fails self-compare only on ppc64le

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29300

            Bug ID: 29300
           Summary: btrfs-progs fails self-compare only on ppc64le
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

This only happens on ppc64le, the check passes on x86_64.

Comparing the ABI of binaries between btrfs-progs-5.18-1.fc36.ppc64le.rpm and
btrfs-progs-5.18-1.fc36.ppc64le.rpm:

======== comparing'btrfs' to itself wrongly yielded result: ===========
  Functions changes summary: 0 Removed, 0 Changed (53 filtered out), 0 Added
functions
  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

===SELF CHECK FAILED for 'btrfs'
==== SELF CHECK SUCCEEDED for 'btrfs-convert' ====
==== SELF CHECK SUCCEEDED for 'mkfs.btrfs' ====
======== comparing'btrfs-image' to itself wrongly yielded result: ===========
  Functions changes summary: 0 Removed, 0 Changed (53 filtered out), 0 Added
functions
  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

===SELF CHECK FAILED for 'btrfs-image'
==== SELF CHECK SUCCEEDED for 'btrfs-find-root' ====
======== comparing'btrfstune' to itself wrongly yielded result: ===========
  Functions changes summary: 0 Removed, 0 Changed (53 filtered out), 0 Added
functions
  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

===SELF CHECK FAILED for 'btrfstune'
======== comparing'btrfs-map-logical' to itself wrongly yielded result:
===========
  Functions changes summary: 0 Removed, 0 Changed (53 filtered out), 0 Added
functions
  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

===SELF CHECK FAILED for 'btrfs-map-logical'
======== comparing'btrfs-select-super' to itself wrongly yielded result:
===========
  Functions changes summary: 0 Removed, 0 Changed (53 filtered out), 0 Added
functions
  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

This is what I did to reproduce it:
$ wget
https://kojipkgs.fedoraproject.org//packages/btrfs-progs/5.18/1.fc36/ppc64le/btrfs-progs-5.18-1.fc36.ppc64le.rpm
$ rpm2cpio btrfs-progs-5.18-1.fc36.ppc64le.rpm | cpio -icumdv
$ abidw --abidiff usr/sbin/btrfs

The crux of the issue is, everything else is a duplicate of this change:

Functions changes summary: 0 Removed, 53 Changed, 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

53 functions with some indirect sub-type change:

  [C] 'function int __btrfs_map_block(btrfs_fs_info*, int, u64, u64*, u64*,
btrfs_multi_bio**, int, u64**)' at volumes.c:1798:1 has some indirect sub-type
changes:
    parameter 1 of type 'btrfs_fs_info*' has sub-type changes:
      in pointed to type 'struct btrfs_fs_info' at ctree.h:1199:1:
        type size hasn't changed
        1 data member change:
          type of 'btrfs_trans_handle* running_transaction' changed:
            in pointed to type 'struct btrfs_trans_handle' at
transaction.h:27:1:
              type size hasn't changed
              1 data member change:
                type of 'btrfs_fs_info* fs_info' changed:
                  pointed to type 'struct btrfs_fs_info' changed, as being
reported
    parameter 6 of type 'btrfs_multi_bio**' has sub-type changes:
      in pointed to type 'btrfs_multi_bio*':
        in pointed to type 'struct btrfs_multi_bio' at volumes.h:107:1:
          type size hasn't changed
          1 data member change:
            type of 'btrfs_bio_stripe stripes[]' changed:
              array element type 'struct btrfs_bio_stripe' changed:
                type size hasn't changed
                1 data member change:
                  type of 'btrfs_device* dev' changed:
                    in pointed to type 'struct btrfs_device' at volumes.h:28:1:
                      type size hasn't changed
                      1 data member change:
                        type of 'btrfs_fs_info* fs_info' changed:
                          pointed to type 'struct btrfs_fs_info' changed at
ctree.h:1199:1, as reported earlier
              type size hasn't changed

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29300] btrfs-progs fails self-compare only on ppc64le

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29300

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27019


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=27019
[Bug 27019] BUILD metabug
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29300] btrfs-progs fails self-compare only on ppc64le

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29300

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
Another one that only seems to be a problem on ppc64le is
qt5-qtdeclarative-5.15.3-2.fc36.ppc64le.rpm no other arches seem to be
impacted.

Comparing the ABI of binaries between
qt5-qtdeclarative-5.15.3-2.fc36.ppc64le.rpm and
qt5-qtdeclarative-5.15.3-2.fc36.ppc64le.rpm:

======== comparing'libQt5Quick.so.5.15.3' to itself wrongly yielded result:
===========
  Functions changes summary: 0 Removed, 1 Changed (252 filtered out), 0 Added
functions
  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

  1 function with some indirect sub-type change:

    [C] 'method QQuickViewPrivate::QQuickViewPrivate()' at qquickview.cpp:76:1
has some indirect sub-type changes:
      implicit parameter 0 of type 'QQuickViewPrivate*' has sub-type changes:
        in pointed to type 'class QQuickViewPrivate' at qquickview_p.h:79:1:
          type size hasn't changed
          1 base class change:
            'class QQuickWindowPrivate' at qquickwindow_p.h:109:1 changed:
              type size hasn't changed
              4 member function insertions:
                'method virtual void QQuickWindowPrivate::clearFocusObject()'
at qquickwindow.cpp:1300:1, virtual at voffset 5/5   
{_ZN19QQuickWindowPrivate16clearFocusObjectEv@@Qt_5.15.3_PRIVATE_API}
                'method virtual QQuickWindowPrivate::~QQuickWindowPrivate(int)'
at qquickwindow.cpp:677:1   
{_ZN19QQuickWindowPrivateD0Ev@@Qt_5.15.3_PRIVATE_API}
                'method virtual QQuickWindowPrivate::~QQuickWindowPrivate(int)'
at qquickwindow.cpp:677:1   
{_ZN19QQuickWindowPrivateD2Ev@@Qt_5.15.3_PRIVATE_API}
                'method virtual QQuickWindowPrivate::~QQuickWindowPrivate(int)'
at qquickwindow.cpp:677:1
              no member function changes (4 filtered);
              1 data member change:
                type of 'QOpenGLVertexArrayObjectHelper* vaoHelper' changed:
                  in pointed to type 'class QOpenGLVertexArrayObjectHelper' at
qopenglvertexarrayobject_p.h:67:1:
                    type size hasn't changed
                    4 data member changes:
                      type of
'QOpenGLVertexArrayObjectHelper::qt_GenVertexArrays_t GenVertexArrays' changed:
                        underlying type 'void (typedef GLsizei, uint*)*'
changed:
                          in pointed to type 'function type void (typedef
GLsizei, uint*)':
                      type of
'QOpenGLVertexArrayObjectHelper::qt_DeleteVertexArrays_t DeleteVertexArrays'
changed:
                        underlying type 'void (typedef GLsizei, const uint*)*'
changed:
                          in pointed to type 'function type void (typedef
GLsizei, const uint*)':
                      type of
'QOpenGLVertexArrayObjectHelper::qt_BindVertexArray_t BindVertexArray' changed:
                        underlying type 'void (typedef uint)*' changed:
                          in pointed to type 'function type void (typedef
uint)':
                      type of
'QOpenGLVertexArrayObjectHelper::qt_IsVertexArray_t IsVertexArray' changed:
                        underlying type 'typedef GLboolean (typedef uint)*'
changed:
                          in pointed to type 'function type typedef GLboolean
(typedef uint)':
          4 member function insertions:
            'method virtual void
QQuickViewPrivate::itemGeometryChanged(QQuickItem*, QQuickGeometryChange, const
QRectF&)' at qquickview.cpp:110:1, virtual at voffset 9/9   
{_ZN17QQuickViewPrivate19itemGeometr
yChangedEP10QQuickItem20QQuickGeometryChangeRK6QRectF@@Qt_5.15.3_PRIVATE_API}
            'method virtual QQuickViewPrivate::~QQuickViewPrivate(int)' at
qquickview.cpp:81:1    {_ZN17QQuickViewPrivateD0Ev@@Qt_5.15.3_PRIVATE_API}
            'method virtual QQuickViewPrivate::~QQuickViewPrivate(int)' at
qquickview.cpp:81:1    {_ZN17QQuickViewPrivateD2Ev@@Qt_5.15.3_PRIVATE_API}
            'method virtual QQuickViewPrivate::~QQuickViewPrivate(int)' at
qquickview.cpp:81:1
          no member function changes (4 filtered);

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29300] btrfs-progs fails self-compare only on ppc64le

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29300

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
Another one which is also arch specific but impacts more arches than the others
mentioned below is: qt6-qtbase-6.3.0-1.fc36.aarch64.rpm

Comparing the ABI of binaries between qt6-qtbase-6.3.0-1.fc36.aarch64.rpm and
qt6-qtbase-6.3.0-1.fc36.aarch64.rpm:

==== SELF CHECK SUCCEEDED for 'libQt6Core.so.6.3.0' ====
======== comparing'libQt6Network.so.6.3.0' to itself wrongly yielded result:
===========
  Functions changes summary: 0 Removed, 0 Changed, 0 Added function
  Variables changes summary: 0 Removed, 2 Changed, 0 Added variables

  2 Changed variables:

    [C] 'QString activeBackendName' was changed to 'static QString
QSslSocketPrivate::activeBackendName' at qsslsocket_p.h:197:1:
      declaration name changed from 'activeBackendName' to
'QSslSocketPrivate::activeBackendName'

    [C] 'QMutex backendMutex' was changed to 'static QMutex
QSslSocketPrivate::backendMutex' at qsslsocket_p.h:196:1:
      declaration name changed from 'backendMutex' to
'QSslSocketPrivate::backendMutex'

===SELF CHECK FAILED for 'libQt6Network.so.6.3.0'

This affects the following arches:
aarch64, armv7hl, i686, ppc64le, s390x

but it does not appear to affect x86_64 for some reason.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29300] btrfs-progs fails self-compare only on ppc64le

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29300

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #3 from dodji at redhat dot com ---
Hello,

This should hopefully be fixed by commit
https://sourceware.org/git/?p=libabigail.git;a=commit;h=4cf16bdbefdb59bd330667a1b8c149aa2239b34c.

Please feel free to close this problem report if the problem is fixed for you.

Sorry for the inconvenience and thank you for taking the time to report this!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29300] btrfs-progs fails self-compare only on ppc64le

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29300

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Ben Woodard <woodard at redhat dot com> ---
This is confirmed to work in the current trunk for btrfs-progs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.