* [Bug default/31045] New: libabigail-2.4: Assertion `__abg_cond__' failed. Aborted (core dumped)
@ 2023-11-08 12:03 paolo.pisati at canonical dot com
2023-11-08 12:04 ` [Bug default/31045] " paolo.pisati at canonical dot com
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: paolo.pisati at canonical dot com @ 2023-11-08 12:03 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=31045
Bug ID: 31045
Summary: libabigail-2.4: Assertion `__abg_cond__' failed.
Aborted (core dumped)
Product: libabigail
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: default
Assignee: dodji at redhat dot com
Reporter: paolo.pisati at canonical dot com
CC: libabigail at sourceware dot org
Target Milestone: ---
Created attachment 15214
--> https://sourceware.org/bugzilla/attachment.cgi?id=15214&action=edit
zfs files that trigger the assert()
While building the zfs-dkms package, in the checkabi target, abidiff core
dumps:
https://launchpadlibrarian.net/696568269/buildlog_ubuntu-noble-amd64.zfs-linux_2.2.0-0ubuntu2_BUILDING.txt.gz
abigail-2.3 was fine, and it started crashing after we moved to abigail-2.4.
I was able to reproduce the issue locally with abigail src from git:
$ abidiff --no-unreferenced-symbols --headers-dir1 include --suppressions
./lib/libnvpair/libnvpair.suppr ./lib/libnvpair/libnvpair.abi
.libs/libnvpair.so
abidiff: ../../src/abg-ir.cc:8004: virtual abigail::ir::decl_base_sptr
abigail::ir::scope_decl::add_member_decl(const abigail::ir::decl_base_sptr&):
Assertion `__abg_cond__' failed.
Aborted (core dumped)
and i bisected it down to this commit:
commit d00a2cc2da9b33be5a6e5376cbee4591c042d3a3 (break5)
Author: Dodji Seketeli <dodji@redhat.com>
Date: Thu May 25 14:15:56 2023 +0200
Bug 30466 - harfbuzz fails self-check on f38
Does it ring any bell?
I'm not familiar with abigail internals, but i'll be happy to test any patch
you throw at me.
I'm attaching a tarball with the offending files.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug default/31045] libabigail-2.4: Assertion `__abg_cond__' failed. Aborted (core dumped)
2023-11-08 12:03 [Bug default/31045] New: libabigail-2.4: Assertion `__abg_cond__' failed. Aborted (core dumped) paolo.pisati at canonical dot com
@ 2023-11-08 12:04 ` paolo.pisati at canonical dot com
2023-11-08 14:52 ` [Bug default/31045] assert violation while setting translation unit for unique types dodji at redhat dot com
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: paolo.pisati at canonical dot com @ 2023-11-08 12:04 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=31045
--- Comment #1 from Paolo Pisati <paolo.pisati at canonical dot com> ---
Created attachment 15215
--> https://sourceware.org/bugzilla/attachment.cgi?id=15215&action=edit
zfs files that trigger the assert()
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug default/31045] assert violation while setting translation unit for unique types
2023-11-08 12:03 [Bug default/31045] New: libabigail-2.4: Assertion `__abg_cond__' failed. Aborted (core dumped) paolo.pisati at canonical dot com
2023-11-08 12:04 ` [Bug default/31045] " paolo.pisati at canonical dot com
@ 2023-11-08 14:52 ` dodji at redhat dot com
2023-11-09 8:53 ` paolo.pisati at canonical dot com
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: dodji at redhat dot com @ 2023-11-08 14:52 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=31045
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2023-11-08
Summary|libabigail-2.4: Assertion |assert violation while
|`__abg_cond__' failed. |setting translation unit
|Aborted (core dumped) |for unique types
--- Comment #2 from dodji at redhat dot com ---
I could reproduce the problem, thank you for reporting it.
The patch
https://sourceware.org/git/?p=libabigail.git;a=commit;h=40d0dcf192389fe9648128c32fe085913cc68eef
should address the issue.
It's in the branch users/dodji/PR31045 that can be browsed at
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/users/dodji/PR31045.
If after testing it, you confirm that it fixes the issue for you, then I'll
merge the patch in the master branch of the git repository.
Thank you for reporting the issue and sorry for the inconvenience.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug default/31045] assert violation while setting translation unit for unique types
2023-11-08 12:03 [Bug default/31045] New: libabigail-2.4: Assertion `__abg_cond__' failed. Aborted (core dumped) paolo.pisati at canonical dot com
2023-11-08 12:04 ` [Bug default/31045] " paolo.pisati at canonical dot com
2023-11-08 14:52 ` [Bug default/31045] assert violation while setting translation unit for unique types dodji at redhat dot com
@ 2023-11-09 8:53 ` paolo.pisati at canonical dot com
2023-11-09 9:06 ` Dodji Seketeli
2023-11-09 9:06 ` dodji at seketeli dot org
` (2 subsequent siblings)
5 siblings, 1 reply; 8+ messages in thread
From: paolo.pisati at canonical dot com @ 2023-11-09 8:53 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=31045
--- Comment #3 from Paolo Pisati <paolo.pisati at canonical dot com> ---
fresh checkout of your PR31045, doesn't build:
$ autoreconf -i
...
$ mkdir build
$ cd build
$ ../configure
...
$ make
make --no-print-directory all-recursive
Making all in include
make[2]: Nothing to be done for 'all'.
Making all in src
CXX abg-traverse.lo
CXX abg-ir.lo
../../src/abg-ir.cc: In function ‘void
abigail::ir::maybe_set_translation_unit(const decl_base_sptr&,
translation_unit*)’:
../../src/abg-ir.cc:8002:5: error: ‘member’ was not declared in this scope
8002 | member->set_translation_unit(tu);
| ^~~~~~
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Bug default/31045] assert violation while setting translation unit for unique types
2023-11-09 8:53 ` paolo.pisati at canonical dot com
@ 2023-11-09 9:06 ` Dodji Seketeli
0 siblings, 0 replies; 8+ messages in thread
From: Dodji Seketeli @ 2023-11-09 9:06 UTC (permalink / raw)
To: paolo.pisati at canonical dot com; +Cc: libabigail
"paolo.pisati at canonical dot com" <sourceware-bugzilla@sourceware.org>
a écrit:
> --- Comment #3 from Paolo Pisati <paolo.pisati at canonical dot com> ---
> fresh checkout of your PR31045, doesn't build:
[...]
> ../../src/abg-ir.cc: In function ‘void
> abigail::ir::maybe_set_translation_unit(const decl_base_sptr&,
> translation_unit*)’:
> ../../src/abg-ir.cc:8002:5: error: ‘member’ was not declared in this scope
> 8002 | member->set_translation_unit(tu);
Ooops, indeed. Could you try again please? I have just fixed that.
Sorry for the inconvenience.
--
Dodji
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug default/31045] assert violation while setting translation unit for unique types
2023-11-08 12:03 [Bug default/31045] New: libabigail-2.4: Assertion `__abg_cond__' failed. Aborted (core dumped) paolo.pisati at canonical dot com
` (2 preceding siblings ...)
2023-11-09 8:53 ` paolo.pisati at canonical dot com
@ 2023-11-09 9:06 ` dodji at seketeli dot org
2023-11-09 12:10 ` paolo.pisati at canonical dot com
2023-11-09 12:30 ` dodji at redhat dot com
5 siblings, 0 replies; 8+ messages in thread
From: dodji at seketeli dot org @ 2023-11-09 9:06 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=31045
--- Comment #4 from dodji at seketeli dot org ---
"paolo.pisati at canonical dot com" <sourceware-bugzilla@sourceware.org>
a écrit:
> --- Comment #3 from Paolo Pisati <paolo.pisati at canonical dot com> ---
> fresh checkout of your PR31045, doesn't build:
[...]
> ../../src/abg-ir.cc: In function ‘void
> abigail::ir::maybe_set_translation_unit(const decl_base_sptr&,
> translation_unit*)’:
> ../../src/abg-ir.cc:8002:5: error: ‘member’ was not declared in this scope
> 8002 | member->set_translation_unit(tu);
Ooops, indeed. Could you try again please? I have just fixed that.
Sorry for the inconvenience.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug default/31045] assert violation while setting translation unit for unique types
2023-11-08 12:03 [Bug default/31045] New: libabigail-2.4: Assertion `__abg_cond__' failed. Aborted (core dumped) paolo.pisati at canonical dot com
` (3 preceding siblings ...)
2023-11-09 9:06 ` dodji at seketeli dot org
@ 2023-11-09 12:10 ` paolo.pisati at canonical dot com
2023-11-09 12:30 ` dodji at redhat dot com
5 siblings, 0 replies; 8+ messages in thread
From: paolo.pisati at canonical dot com @ 2023-11-09 12:10 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=31045
--- Comment #5 from Paolo Pisati <paolo.pisati at canonical dot com> ---
Applied, rebuilt abigail and it builds zfs-dkms successfully now, thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug default/31045] assert violation while setting translation unit for unique types
2023-11-08 12:03 [Bug default/31045] New: libabigail-2.4: Assertion `__abg_cond__' failed. Aborted (core dumped) paolo.pisati at canonical dot com
` (4 preceding siblings ...)
2023-11-09 12:10 ` paolo.pisati at canonical dot com
@ 2023-11-09 12:30 ` dodji at redhat dot com
5 siblings, 0 replies; 8+ messages in thread
From: dodji at redhat dot com @ 2023-11-09 12:30 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=31045
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from dodji at redhat dot com ---
Thanks!
I have applied the patch
https://inbox.sourceware.org/libabigail/87h6lvdsb1.fsf@redhat.com/ to the
master branch of the Git repository. That fix should be available in
libabigail 2.5.
Thank you for reporting this problem and sorry for the inconvenience.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-11-09 12:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-08 12:03 [Bug default/31045] New: libabigail-2.4: Assertion `__abg_cond__' failed. Aborted (core dumped) paolo.pisati at canonical dot com
2023-11-08 12:04 ` [Bug default/31045] " paolo.pisati at canonical dot com
2023-11-08 14:52 ` [Bug default/31045] assert violation while setting translation unit for unique types dodji at redhat dot com
2023-11-09 8:53 ` paolo.pisati at canonical dot com
2023-11-09 9:06 ` Dodji Seketeli
2023-11-09 9:06 ` dodji at seketeli dot org
2023-11-09 12:10 ` paolo.pisati at canonical dot com
2023-11-09 12:30 ` dodji at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).