From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Andreas Schwab <schwab@suse.de>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 2/2] New internal function __access_noerrno
Date: Thu, 10 Nov 2016 18:26:00 -0000 [thread overview]
Message-ID: <114554f7-e58c-6f50-923e-3f364fe19f7b@linaro.org> (raw)
In-Reply-To: <mvmbmxn8djq.fsf@hawking.suse.de>
On 10/11/2016 15:12, Andreas Schwab wrote:
> On Nov 10 2016, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
>
>> diff --git a/hurd/hurd.h b/hurd/hurd.h
>> index ec07827..8bcb1ec 100644
>> --- a/hurd/hurd.h
>> +++ b/hurd/hurd.h
>> @@ -75,6 +75,36 @@ __hurd_fail (error_t err)
>> errno = err;
>> return -1;
>> }
>> +
>> +_HURD_H_EXTERN_INLINE int
>> +__hurd_fail_noerrno (error_t err)
>> +{
>> + switch (err)
>> + {
>> + case EMACH_SEND_INVALID_DEST:
>> + case EMIG_SERVER_DIED:
>> + /* The server has disappeared! */
>> + err = EIEIO;
>> + break;
>> +
>> + case KERN_NO_SPACE:
>> + err = ENOMEM;
>> + break;
>> +
>> + case KERN_INVALID_ARGUMENT:
>> + err = EINVAL;
>> + break;
>> +
>> + case 0:
>> + return 0;
>> +
>> + default:
>> + break;
>> + }
>> +
>> + errno = err;
>
> Isn't that supposed to _not_ set errno?
>
> Andreas.
>
Oops, fixed it locally.
next prev parent reply other threads:[~2016-11-10 18:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 17:04 [PATCH 1/2] Consolidate Linux access implementation Adhemerval Zanella
2016-11-10 17:04 ` [PATCH 2/2] New internal function __access_noerrno Adhemerval Zanella
2016-11-10 17:12 ` Andreas Schwab
2016-11-10 18:26 ` Adhemerval Zanella [this message]
2016-11-10 17:53 ` Siddhesh Poyarekar
2016-11-10 18:31 ` Adhemerval Zanella
2016-11-16 13:27 ` Adhemerval Zanella
2016-11-16 13:44 ` Adhemerval Zanella
2016-11-16 16:27 ` Carlos O'Donell
2016-11-16 18:29 ` Joseph Myers
2016-11-17 20:53 ` Kalle Olavi Niemitalo
2016-11-17 21:30 ` Adhemerval Zanella
2016-11-18 0:21 ` Kalle Olavi Niemitalo
2016-11-18 18:54 ` Adhemerval Zanella
2016-11-19 3:09 ` Siddhesh Poyarekar
2016-11-21 5:12 ` Kalle Olavi Niemitalo
2016-11-21 12:45 ` Adhemerval Zanella
2016-11-10 17:44 ` [PATCH 1/2] Consolidate Linux access implementation Siddhesh Poyarekar
2016-11-16 13:16 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=114554f7-e58c-6f50-923e-3f364fe19f7b@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).