From: Kalle Olavi Niemitalo <kon@iki.fi>
To: libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 2/2] New internal function __access_noerrno
Date: Fri, 18 Nov 2016 00:21:00 -0000 [thread overview]
Message-ID: <87inrliqmx.fsf@Niukka.kon.iki.fi> (raw)
In-Reply-To: <e31f40f7-3b05-0540-a898-a61b94916405@linaro.org> (Adhemerval Zanella's message of "Thu, 17 Nov 2016 19:30:38 -0200")
Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
> Below is all the fixes you proposed, if you think it is ok I will
> prepare a patch and commit.
Thanks. It looks like an improvement.
I'd like to do some testing during the weekend.
However, I suspect that this __access_noerrno may be unsafe to run
during initialization of tunables on the Hurd. access_common calls
__hurd_file_name_lookup, which calls __hurd_file_name_lookup_retry,
which can use errno, __strtoul_internal, _itoa, strcpy, and memcmp.
I'm not yet sure whether this is a problem, and I'm not asking you
to spend time on it.
next prev parent reply other threads:[~2016-11-18 0:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 17:04 [PATCH 1/2] Consolidate Linux access implementation Adhemerval Zanella
2016-11-10 17:04 ` [PATCH 2/2] New internal function __access_noerrno Adhemerval Zanella
2016-11-10 17:12 ` Andreas Schwab
2016-11-10 18:26 ` Adhemerval Zanella
2016-11-10 17:53 ` Siddhesh Poyarekar
2016-11-10 18:31 ` Adhemerval Zanella
2016-11-16 13:27 ` Adhemerval Zanella
2016-11-16 13:44 ` Adhemerval Zanella
2016-11-16 16:27 ` Carlos O'Donell
2016-11-16 18:29 ` Joseph Myers
2016-11-17 20:53 ` Kalle Olavi Niemitalo
2016-11-17 21:30 ` Adhemerval Zanella
2016-11-18 0:21 ` Kalle Olavi Niemitalo [this message]
2016-11-18 18:54 ` Adhemerval Zanella
2016-11-19 3:09 ` Siddhesh Poyarekar
2016-11-21 5:12 ` Kalle Olavi Niemitalo
2016-11-21 12:45 ` Adhemerval Zanella
2016-11-10 17:44 ` [PATCH 1/2] Consolidate Linux access implementation Siddhesh Poyarekar
2016-11-16 13:16 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inrliqmx.fsf@Niukka.kon.iki.fi \
--to=kon@iki.fi \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).