From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: [PATCH 1/2] Consolidate Linux access implementation
Date: Thu, 10 Nov 2016 17:04:00 -0000 [thread overview]
Message-ID: <1478797446-12213-1-git-send-email-adhemerval.zanella@linaro.org> (raw)
This patch consolidates the Linux access implementation on
sysdeps/unix/sysv/linux/access.c. Similar to auto-generation through
syscalls.list, __NR_access is check and __NR_faccessat is used only
for newer architectures (where __NR_access is not defined).
Checked on x86_64.
* sysdeps/unix/sysv/linux/access.c: New file.
* sysdeps/unix/sysv/linux/generic/access.c: Remove file.
---
ChangeLog | 5 +++++
sysdeps/unix/sysv/linux/access.c | 32 ++++++++++++++++++++++++++++++++
sysdeps/unix/sysv/linux/generic/access.c | 31 -------------------------------
3 files changed, 37 insertions(+), 31 deletions(-)
create mode 100644 sysdeps/unix/sysv/linux/access.c
delete mode 100644 sysdeps/unix/sysv/linux/generic/access.c
diff --git a/sysdeps/unix/sysv/linux/access.c b/sysdeps/unix/sysv/linux/access.c
new file mode 100644
index 0000000..cdb7908
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/access.c
@@ -0,0 +1,32 @@
+/* Copyright (C) 2016 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library. If not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <fcntl.h>
+#include <unistd.h>
+#include <sysdep-cancel.h>
+
+/* Test for access to FILE. */
+int
+__access (const char *file, int type)
+{
+#ifdef __NR_access
+ return INLINE_SYSCALL_CALL (access, file, type);
+#else
+ return INLINE_SYSCALL_CALL (faccessat, AT_FDCWD, file, type);
+#endif
+}
+weak_alias (__access, access)
diff --git a/sysdeps/unix/sysv/linux/generic/access.c b/sysdeps/unix/sysv/linux/generic/access.c
deleted file mode 100644
index 586aa93..0000000
--- a/sysdeps/unix/sysv/linux/generic/access.c
+++ /dev/null
@@ -1,31 +0,0 @@
-/* Copyright (C) 2011-2016 Free Software Foundation, Inc.
- This file is part of the GNU C Library.
- Contributed by Chris Metcalf <cmetcalf@tilera.com>, 2011.
-
- The GNU C Library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
-
- The GNU C Library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
-
- You should have received a copy of the GNU Lesser General Public
- License along with the GNU C Library. If not, see
- <http://www.gnu.org/licenses/>. */
-
-#include <errno.h>
-#include <stddef.h>
-#include <unistd.h>
-#include <fcntl.h>
-#include <sysdep-cancel.h>
-
-/* Test for access to FILE. */
-int
-__access (const char *file, int type)
-{
- return INLINE_SYSCALL (faccessat, 3, AT_FDCWD, file, type);
-}
-weak_alias (__access, access)
--
2.7.4
next reply other threads:[~2016-11-10 17:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 17:04 Adhemerval Zanella [this message]
2016-11-10 17:04 ` [PATCH 2/2] New internal function __access_noerrno Adhemerval Zanella
2016-11-10 17:12 ` Andreas Schwab
2016-11-10 18:26 ` Adhemerval Zanella
2016-11-10 17:53 ` Siddhesh Poyarekar
2016-11-10 18:31 ` Adhemerval Zanella
2016-11-16 13:27 ` Adhemerval Zanella
2016-11-16 13:44 ` Adhemerval Zanella
2016-11-16 16:27 ` Carlos O'Donell
2016-11-16 18:29 ` Joseph Myers
2016-11-17 20:53 ` Kalle Olavi Niemitalo
2016-11-17 21:30 ` Adhemerval Zanella
2016-11-18 0:21 ` Kalle Olavi Niemitalo
2016-11-18 18:54 ` Adhemerval Zanella
2016-11-19 3:09 ` Siddhesh Poyarekar
2016-11-21 5:12 ` Kalle Olavi Niemitalo
2016-11-21 12:45 ` Adhemerval Zanella
2016-11-10 17:44 ` [PATCH 1/2] Consolidate Linux access implementation Siddhesh Poyarekar
2016-11-16 13:16 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478797446-12213-1-git-send-email-adhemerval.zanella@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).