public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [hurd,commited] htl: Add missing fork.h
Date: Wed, 24 Mar 2021 13:31:36 +0100	[thread overview]
Message-ID: <20210324123136.x5ab7fkrcm557enm@begin> (raw)
In-Reply-To: <f68f01a0-db26-5d42-f402-fdf613d0cc75@linaro.org>

Adhemerval Zanella, le mer. 24 mars 2021 09:29:44 -0300, a ecrit:
> On 23/03/2021 21:20, Samuel Thibault wrote:
> > 2b47727c68b6 ("posix: Consolidate register-atfork") introduced a fork.h
> > header to declare the atfork unregister hook, but was missing adding it
> > for htl.
> > 
> > This fixes tst-atfork2.
> 
> Both lowlevellock.h and register-atfork.h are common headers,
> I think it would be better to just add them to generic fork.h header.

Ok but perhaps there was a reason why you didn't do it in your commit?

Samuel

  reply	other threads:[~2021-03-24 12:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-24  0:20 Samuel Thibault
2021-03-24 12:29 ` Adhemerval Zanella
2021-03-24 12:31   ` Samuel Thibault [this message]
2021-03-24 12:40     ` Adhemerval Zanella
2021-03-24 12:45       ` Samuel Thibault
2021-03-24 12:56         ` Adhemerval Zanella
2021-03-24 13:00           ` Samuel Thibault
2021-03-24 13:04             ` Adhemerval Zanella
2021-03-24 13:09               ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210324123136.x5ab7fkrcm557enm@begin \
    --to=samuel.thibault@ens-lyon.org \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).