From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [hurd,commited] htl: Add missing fork.h
Date: Wed, 24 Mar 2021 10:09:09 -0300 [thread overview]
Message-ID: <ee493068-9b48-61c6-9ea7-747a16c1718c@linaro.org> (raw)
In-Reply-To: <79f51c68-8820-1994-8802-91411a705de3@linaro.org>
On 24/03/2021 10:04, Adhemerval Zanella wrote:
>
>
> On 24/03/2021 10:00, Samuel Thibault wrote:
>> Adhemerval Zanella, le mer. 24 mars 2021 09:56:47 -0300, a ecrit:
>>> On 24/03/2021 09:45, Samuel Thibault wrote:
>>>> Adhemerval Zanella, le mer. 24 mars 2021 09:40:36 -0300, a ecrit:
>>>>> Why exactly tst-atfork2 fails without this includes?
>>>>
>>>> It misses the atfork unregister hook called at module unload.
>>>
>>> Ok, but *why* exactly? The sysdeps/htl/pt-atfork.c already
>>> includes register-atfork.h after the fork.h inclusion.
>>
>> It's not pt-atfork.c which needs UNREGISTER_ATFORK, but
>> stdlib/cxa_finalize, which gets it from fork.h
>
> Thanks, this is a good indication that is better to just remove
> the ifdef UNREGISTER_ATFORK from cxa_finalize (since now it is
> defined on generic implementation).
And I think the fork.h header is not really required here, it is
being used solely to define the NPTL specific __fork_generation,
which Florian recent patch moves to libc.so. So I think we can
move this declaration to another internal header and remove
fork.h.
prev parent reply other threads:[~2021-03-24 13:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 0:20 Samuel Thibault
2021-03-24 12:29 ` Adhemerval Zanella
2021-03-24 12:31 ` Samuel Thibault
2021-03-24 12:40 ` Adhemerval Zanella
2021-03-24 12:45 ` Samuel Thibault
2021-03-24 12:56 ` Adhemerval Zanella
2021-03-24 13:00 ` Samuel Thibault
2021-03-24 13:04 ` Adhemerval Zanella
2021-03-24 13:09 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee493068-9b48-61c6-9ea7-747a16c1718c@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).