From: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
Wilco Dijkstra via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] AArch64: Add hp-timing.h
Date: Mon, 28 Jun 2021 12:49:27 +0100 [thread overview]
Message-ID: <20210628114927.GM13058@arm.com> (raw)
In-Reply-To: <87h7hiuu3d.fsf@oldenburg.str.redhat.com>
The 06/28/2021 13:06, Florian Weimer wrote:
> * Wilco Dijkstra:
> > Hi Florian,
> >> Is the MSR called cntcvt_el0 or cntvct_el0?
> >
> > cntvct_el0 - it's just a random combination of characters!
>
> Okay, then please fix the other occurence that is a typo.
>
> >> I'm clearly missing something: If this is broken on some kernels, how is
> >> this disabled?
> >
> > It's not enabled just to be extremely conservative - however I don't
> > believe this is an issue in practice since it works fine even on the
> > first AArch64 boards and servers.
>
> I meant: How is this disabled in glibc on older kernels? Or is this
> code just dormant as of now?
iirc linux devs asked that it is only used in vdso so
that it is under the kernel's control in case there
are implementation issues (vdso is easy to disable
and on some system it got disabled for timer reasons).
is hp-timing.h for some internal benchmarks only?
if no, then i think we should get the opinion of
linux maintainers before we use this in glibc.
next prev parent reply other threads:[~2021-06-28 11:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 10:11 Wilco Dijkstra
2021-06-28 10:20 ` Florian Weimer
2021-06-28 10:53 ` Wilco Dijkstra
2021-06-28 11:06 ` Florian Weimer
2021-06-28 11:35 ` Wilco Dijkstra
2021-06-28 11:39 ` Florian Weimer
2021-06-28 11:49 ` Szabolcs Nagy [this message]
2021-06-28 11:55 ` Adhemerval Zanella
2021-06-28 12:10 ` Wilco Dijkstra
2021-06-28 13:15 ` Adhemerval Zanella
2021-06-28 14:24 ` Wilco Dijkstra
2021-06-28 14:46 ` Adhemerval Zanella
2021-06-28 19:16 ` Wilco Dijkstra
2021-06-30 8:46 ` Szabolcs Nagy
2021-06-30 8:55 ` Florian Weimer
2021-06-30 9:33 ` Siddhesh Poyarekar
2021-07-01 10:21 ` Wilco Dijkstra
2021-07-01 13:48 ` Szabolcs Nagy
2021-07-01 15:33 ` Wilco Dijkstra
2021-07-06 11:33 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628114927.GM13058@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).