public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: Florian Weimer <fweimer@redhat.com>,
	Szabolcs Nagy via Libc-alpha <libc-alpha@sourceware.org>,
	Siddhesh Poyarekar <siddhesh@redhat.com>
Subject: Re: [PATCH] AArch64: Add hp-timing.h
Date: Thu, 1 Jul 2021 14:48:10 +0100	[thread overview]
Message-ID: <20210701134810.GF14854@arm.com> (raw)
In-Reply-To: <VE1PR08MB5599C5458C811FA4CE866C8A83009@VE1PR08MB5599.eurprd08.prod.outlook.com>

The 07/01/2021 11:21, Wilco Dijkstra wrote:
> Hi Florian,
> 
> > This commit would not be entirely accurate.  We install and ship the
> > benchtests, so they need to use a stable ISA (and kernel ABI).
> >
> > If the benchtests are like the testsuite and are not intended to be
> > installed and distributed, we probably need to make downstream changes.
> 
> Is this something distro specific? I don't see it in the GLIBC install directory after
> "make install" or anywhere on my system.
> 
> In any case, there is no ABI change here - cntvct_el0 is always allowed in userspace.

then just say the commit only affects the glibc benchmark code.

i'm happy to accept the commit with that.

if we want to use it in the dynamic linker then we should
dig into the potential kernel issues (what versions are
affected etc)

  reply	other threads:[~2021-07-01 13:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 10:11 Wilco Dijkstra
2021-06-28 10:20 ` Florian Weimer
2021-06-28 10:53   ` Wilco Dijkstra
2021-06-28 11:06     ` Florian Weimer
2021-06-28 11:35       ` Wilco Dijkstra
2021-06-28 11:39         ` Florian Weimer
2021-06-28 11:49       ` Szabolcs Nagy
2021-06-28 11:55         ` Adhemerval Zanella
2021-06-28 12:10         ` Wilco Dijkstra
2021-06-28 13:15           ` Adhemerval Zanella
2021-06-28 14:24           ` Wilco Dijkstra
2021-06-28 14:46             ` Adhemerval Zanella
2021-06-28 19:16               ` Wilco Dijkstra
2021-06-30  8:46 ` Szabolcs Nagy
2021-06-30  8:55   ` Florian Weimer
2021-06-30  9:33     ` Siddhesh Poyarekar
2021-07-01 10:21     ` Wilco Dijkstra
2021-07-01 13:48       ` Szabolcs Nagy [this message]
2021-07-01 15:33         ` Wilco Dijkstra
2021-07-06 11:33       ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210701134810.GF14854@arm.com \
    --to=szabolcs.nagy@arm.com \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=siddhesh@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).